Page MenuHomeWildfire Games
Differential D3057

Do not use g_FrequencyFilter to calculate the real frame time.
Needs ReviewPublic
Actions

Authored by wraitii on Nov 4 2020, 5:45 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This would make it possible to use less precise timers, enabling deletion of most code in D2726 and fixing it.

Test Plan

Compile, try to notice if the game framerate seems smoother than before.

The question that must be answered is: "can this be done without making the game twitchy?"

Diff Detail

Event Timeline

wraitii created this revision.Nov 4 2020, 5:45 PM
wraitii mentioned this in D1923: pthread -> std::thread - Remove clock frequency calculations.Nov 4 2020, 5:51 PM
Vulcan added a comment.Nov 4 2020, 7:13 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:155:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:155:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface.a(precompiled.o) has no symbols
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(vfs_path.o) has no symbols
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1716/display/redirect

Harbormaster completed remote builds in B13428: Diff 13714.Nov 4 2020, 7:13 PM
wraitii requested review of this revision.Nov 4 2020, 7:13 PM
Stan added a subscriber: Stan.Nov 6 2020, 10:53 AM

I tested this, it works but it does not make it smoother for me. My FPS oscillates from 170 to 220 on acropolis_bay_2p

source/main.cpp
333–337
395

Useless cast.

wraitii added a comment.Nov 6 2020, 1:53 PM
In D3057#134540, @Stan wrote:

I tested this, it works but it does not make it smoother for me. My FPS oscillates from 170 to 220 on acropolis_bay_2p

The 'expectation' is that it would make things noticeably less smooth, actually.

vladislavbelov added a subscriber: vladislavbelov.Nov 6 2020, 7:45 PM
vladislavbelov added inline comments.
source/main.cpp
334

That's the bad value. You might get a huge realTimeSinceLastFrame to update some components.

337

How this difference solves the problem with spikes (because of CPU/GPU stall, OS pause)?

wraitii edited the test plan for this revision. (Show Details)Nov 7 2020, 7:56 AM
phosit added a subscriber: phosit.May 14 2023, 3:38 PM

Awesome, How such a small change make such a big difference. I can play with 7FPS and reasonable smooth scroling and console-open/close-ing.
Sure part of that might be placebo, but that can't explain everything. ^^

To clarify (because i was fairly confused when first reading the diff).
This is not about the FPS shown on screen. But about how far the camera does travel in one frame. Also it's about how far the console "travels" and about something inside the simulation (I don't think it's the actual progress of the simulation since it's _real_ time not game time).
Lets say one frame does take double the time. In the next frame the camera should travel double the distance.
Previously the time was smoothed. That's usefull if you don't want fast changes but is the wrong aproach for this usecase.

You should switch from timer_Time to steady_clock while at it.
last_time doesn't have to be static (when placed outside of the loop).
FrequencyFilter::SmoothedFrequency could be removed.

The question that must be answered is: "can this be done without making the game twitchy?"

In wat conditions do you think this becomes more twitchy then the old version?

phosit mentioned this in D5211: Use std functionality for fps-limit.Dec 13 2023, 6:03 PM

Revision Contents
Changeset List

PathSize
source/
17 lines

Diff 13714

View Options

source/main.cpp

Loading...
Wildfire Games · Phabricator