Differential D3065

Allow ejecting single entities from allied garrisonHolder when allowed to controll all.
ClosedPublic
Actions

Authored by Freagarach on Nov 6 2020, 5:55 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP24505: Allow ejecting single entities from non-owned garrisonHolder when allowed to…

Summary

Found by @wraitii in D1960.

Test Plan

Verify this works by trying to eject single entities owned by an ally from an allied garrisonHolder with and without this patch, with controlAllUnits on.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Nov 6 2020, 5:55 PM

Owners added a subscriber: Restricted Owners Package.Nov 6 2020, 5:55 PM

Freagarach published this revision for review.Nov 6 2020, 5:55 PM

Harbormaster completed remote builds in B13481: Diff 13765.Nov 6 2020, 6:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2021, 7:32 AM

Closed by commit rP24505: Allow ejecting single entities from non-owned garrisonHolder when allowed to… (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP24505: Allow ejecting single entities from non-owned garrisonHolder when allowed to….

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

selection_panels.js

8 lines

Diff 14969

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Allow ejecting single entities from allied garrisonHolder when allowed to controll all.ClosedPublicActions