Page MenuHomeWildfire Games

Fix visual-replays not processing turn 0 commands.
Needs ReviewPublic

Authored by wraitii on Sat, Nov 7, 10:32 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Trac Tickets
#5546
Summary

As noted in #5546, the Turn 0 commands are not executed in visual replays. That is because the visual replay turn manager pushes commands on "NotifyFinished
Update", which is run for the first time after turn 0 has been processed.

I couldn't find any particular reason why rP16727 (the OG visual replay diff) or rP17746 didn't use FinishedOwnCommands instead, which seems more logical.
This reverts some hacky-looking code from rP17746.

(Note that MP games can't actually have commands on turn 0.)

Reported by: Freagarach

Test Plan

Run a visual replay with commands on turn 0.

Event Timeline

wraitii created this revision.Sat, Nov 7, 10:32 AM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1772/display/redirect

wraitii requested review of this revision.Sat, Nov 7, 10:41 AM