Page MenuHomeWildfire Games

Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components
Needs ReviewPublic

Authored by wraitii on Nov 9 2020, 6:50 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Trac Tickets
#5566
Summary

This further decorrelates TERRAIN_TILE_SIZE from other components.

Test Plan

Review the changes systematically.

Event Timeline

wraitii created this revision.Nov 9 2020, 6:50 PM
Owners added a subscriber: Restricted Owners Package.Nov 9 2020, 6:50 PM
Vulcan added a comment.Nov 9 2020, 6:52 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3460/display/redirect

Vulcan added a comment.Nov 9 2020, 6:53 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/2907/display/redirect

Vulcan added a comment.Nov 9 2020, 7:09 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1808/display/redirect

wraitii requested review of this revision.Nov 9 2020, 7:09 PM
wraitii updated this revision to Diff 15906.Feb 9 2021, 5:35 PM
wraitii retitled this revision from [WIP] Terrain decorrelation with pathfinder and other components. to Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components.
wraitii edited the summary of this revision. (Show Details)

Found the issue. Also use multiples of pathfinding navcell size in unitMotion since that's what relevant.

Vulcan added a comment.Feb 9 2021, 5:36 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4858/display/redirect

Vulcan added a comment.Feb 9 2021, 5:38 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/3200/display/redirect

wraitii updated this revision to Diff 15907.Feb 9 2021, 5:43 PM

A few more usages went through. This mostly decouples components from the terrain_tile_size, which means we know 'simply' need to decouple graphical stuff...

Vulcan added a comment.Feb 9 2021, 5:44 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4859/display/redirect

Vulcan added a comment.Feb 9 2021, 5:45 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/3201/display/redirect