Fix JS OOM in tests following rP24180
ClosedPublic
Actions

Authored by wraitii on Nov 14 2020, 3:41 PM.

Details

Reviewers: None
Commits: rP24182: Fix JS OOM in tests following rP24180
rP24180: Explicitly make ScriptInterface a Compartment wrapper.

Summary

rP24180 made ScriptInterface not recreate a new JSContext since it becomes a compartment wrapper, but that means we need to GC tests or they might OOM.

To make it mostly seamless, GC on any test setup. The JS tests are pretty close to the 16Mb limit as it stands so GC them manually too, for good measure.

Refs #4893

Test Plan

Run tests.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Nov 14 2020, 3:41 PM

Build was aborted.

builderr-debug-gcc6.txt
make[1]: *** [obj/test_Debug/test_TextureManager.o] Terminated
make: *** [test] Terminated

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3536/display/redirect

Correct rebase

Harbormaster completed remote builds in B13640: Diff 13913.Nov 14 2020, 4:11 PM

wraitii requested review of this revision.Nov 14 2020, 4:11 PM

wraitii added a commit: rP24180: Explicitly make ScriptInterface a Compartment wrapper..Nov 14 2020, 4:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2020, 4:14 PM

Closed by commit rP24182: Fix JS OOM in tests following rP24180 (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24182: Fix JS OOM in tests following rP24180.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

simulation2/

components/

tests/

test_scripts.h

4 lines

test_setup.cpp

8 lines

Diff 13914

View Options

ps/trunk/source/simulation2/components/tests/test_scripts.h