Page MenuHomeWildfire Games

More header tweaks
Needs ReviewPublic

Authored by wraitii on Sat, Nov 21, 12:35 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

More header changes -> forward declaration, removed useless includes, and add MessageTypes.h to the simulation precompiled header since it's a rather hefty one and included in 35+ files, so probably good to add it there regardless of recompilation time. I'll check on CI.

Test Plan

Compile.

Unit TestsFailed

TimeTest
0 msJenkins > cxxtest_debug.xml::[failed-to-read]
Failed to read test report file E:\Jenkins\workspace\vs2015-differential\cxxtest_debug.xml org.dom4j.DocumentException: Error on line 347 of document : Content is not allowed in trailing section. at org.dom4j.io.SAXReader.read(SAXReader.java:511)
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAtlasObjectXML::test_parse_attributes1
View Full Test Results (1 Failed · 1,021 Passed)

Event Timeline

wraitii created this revision.Sat, Nov 21, 12:35 PM
Owners added a subscriber: Restricted Owners Package.Sat, Nov 21, 12:35 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface.a(precompiled.o) has no symbols
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel.a(vfs_path.o) has no symbols
In file included from ../../../source/graphics/tests/test_Camera.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/graphics/tests/test_Camera.h:168:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CVector3D(-101.0f, -101.0f, 101.0f),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from ../../../source/simulation2/tests/test_SerializeTemplates.cpp:17:
/Users/wfg/Jenkins/workspace/macos-differential/source/simulation2/tests/test_SerializeTemplates.h:39:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        3, 0, 1, 4, 1, 5
                        ^~~~~~~~~~~~~~~~
                        {               }
1 warning generated.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2059/display/redirect

wraitii requested review of this revision.Sat, Nov 21, 1:39 PM
Stan added a subscriber: Stan.Sat, Nov 21, 1:42 PM

Also copyright headers.

source/gui/CGUI.h
150

Can't this return a smart pointer?

We gained a big 30 seconds of 23 minutes compilation time on the CI with is like 2% :p

source/gui/CGUI.h
150

The best I could return is a reference to the unique_ptr, but it's actually used for pointer-pointer comparisons so it makes more sense to return a naked pointer.

wraitii updated this revision to Diff 14145.Sun, Nov 22, 3:17 PM

Fix PCH (I think) and remove the preocmpilde change, had doubts it was worth it.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
../../../source/gui/CGUI.cpp:66:21: error: unknown type name 'CGUIDummyObject'
        : m_BaseObject(new CGUIDummyObject(*this)),
                           ^
../../../source/gui/CGUI.cpp:355:19: error: redefinition of 'GetBaseObject'
IGUIObject* CGUI::GetBaseObject()
                  ^
../../../source/gui/CGUI.cpp:350:19: note: previous definition is here
IGUIObject* CGUI::GetBaseObject()
                  ^
2 errors generated.
make[1]: *** [obj/gui_Debug/CGUI.o] Error 1
make[1]: *** Waiting for unfinished jobs....
../../../source/gui/GUIObjectTypes.cpp:46:26: error: use of undeclared identifier 'CGUIDummyObject'
        AddObjectType("empty", &CGUIDummyObject::ConstructObject);
                                ^
1 error generated.
make[1]: *** [obj/gui_Debug/GUIObjectTypes.o] Error 1
make: *** [gui] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2078/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3179/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
../../../source/gui/CGUI.cpp: In constructor 'CGUI::CGUI(const std::shared_ptr<ScriptContext>&)':
../../../source/gui/CGUI.cpp:66:21: error: expected type-specifier before 'CGUIDummyObject'
  : m_BaseObject(new CGUIDummyObject(*this)),
                     ^~~~~~~~~~~~~~~
../../../source/gui/CGUI.cpp: At global scope:
../../../source/gui/CGUI.cpp:355:13: error: redefinition of 'IGUIObject* CGUI::GetBaseObject()'
 IGUIObject* CGUI::GetBaseObject()
             ^~~~
../../../source/gui/CGUI.cpp:350:13: note: 'IGUIObject* CGUI::GetBaseObject()' previously defined here
 IGUIObject* CGUI::GetBaseObject()
             ^~~~
make[1]: *** [obj/gui_Debug/CGUI.o] Error 1
make: *** [gui] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3736/display/redirect

wraitii updated this revision to Diff 14155.Sun, Nov 22, 5:57 PM

More changes. This removes boost from the precompiled headers (except in the GUI one because of scriptInterface.h).

I've got some hope that this improves compilation times.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
In file included from ../../../source/lib/file/vfs/vfs_path.h:26:0,
                 from ../../../source/gui/GUIManager.h:21,
                 from ../../../source/rlinterface/RLInterface.cpp:24:
../../../source/lib/path.h: In member function 'Path Path::BeforeCommon(Path) const':
../../../source/lib/path.h:250:80: error: 'replace' was not declared in this scope
    replace(other.path.begin(), other.path.end(), other.separator, ret.separator);
                                                                                ^
make[1]: *** [obj/rlinterface_Debug/RLInterface.o] Error 1
make: *** [rlinterface] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3742/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3185/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:29:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string content;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:33:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string json_cmd;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:45:26: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
const static std::string EMPTY_STATE;
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:66:15: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
                std::string m_GameState;
                            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:71:18: warning: private field 'm_ScenarioConfig' is not used [-Wunused-private-field]
                ScenarioConfig m_ScenarioConfig;
                               ^
1 warning and 4 errors generated.
make[1]: *** [obj/rlinterface_Debug/RLInterface.o] Error 1
make: *** [rlinterface] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2085/display/redirect

wraitii updated this revision to Diff 14157.Sun, Nov 22, 9:31 PM

Hard fall down the rabbit hole. Most of the header changes should be sound, the precompiled changes might be looked at more, but some testing locally has shown them to be positive overall. I've also made ScriptInterface.h not include boost, since we could forward-declare. Not so easy with the component manager ATM, but that has other problems.

I haven't tested without PCH yet.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:29:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string content;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:33:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string json_cmd;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:45:26: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
const static std::string EMPTY_STATE;
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:66:15: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
                std::string m_GameState;
                            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:71:18: warning: private field 'm_ScenarioConfig' is not used [-Wunused-private-field]
                ScenarioConfig m_ScenarioConfig;
                               ^
1 warning and 4 errors generated.
make[1]: *** [obj/rlinterface_Debug/RLInterface.o] Error 1
make: *** [rlinterface] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2087/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
In file included from ../../../source/lib/file/vfs/vfs_path.h:26:0,
                 from ../../../source/gui/GUIManager.h:21,
                 from ../../../source/rlinterface/RLInterface.cpp:24:
../../../source/lib/path.h: In member function 'Path Path::BeforeCommon(Path) const':
../../../source/lib/path.h:250:4: error: 'replace' is not a member of 'std'
    std::replace(other.path.begin(), other.path.end(), other.separator, ret.separator);
    ^~~
make[1]: *** [obj/rlinterface_Debug/RLInterface.o] Error 1
make: *** [rlinterface] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3744/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3187/display/redirect

wraitii updated this revision to Diff 14158.Mon, Nov 23, 9:13 AM

Did a clean no-pch build, hoping this builds.

Owners added a subscriber: Restricted Owners Package.Mon, Nov 23, 9:13 AM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:29:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string content;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:33:14: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
        std::string json_cmd;
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:45:26: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
const static std::string EMPTY_STATE;
                         ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:66:15: error: implicit instantiation of undefined template 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >'
                std::string m_GameState;
                            ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iosfwd:193:33: note: template is declared here
    class _LIBCPP_TYPE_VIS_ONLY basic_string;
                                ^
In file included from ../../../source/rlinterface/RLInterface.cpp:22:
../../../source/rlinterface/RLInterface.h:71:18: warning: private field 'm_ScenarioConfig' is not used [-Wunused-private-field]
                ScenarioConfig m_ScenarioConfig;
                               ^
1 warning and 4 errors generated.
make[1]: *** [obj/rlinterface_Debug/RLInterface.o] Error 1
make: *** [rlinterface] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2088/display/redirect

On a full PCH build, it took 414 seconds with the patch and 438 without. About 5% better.

(I also still don't get why I can compile but CI can't... Need to sort that out).

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3188/display/redirect

wraitii updated this revision to Diff 14159.Mon, Nov 23, 9:42 AM

Maybe fix RLInterface...

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface_dbg.a(precompiled.o) has no symbols
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/lib/file/archive/archive.cpp:28:
In file included from ../../../source/lib/file/archive/archive.h:30:
../../../source/lib/file/file_system.h:76:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<CFileInfo> CFileInfos;
        ~~~~~^
../../../source/lib/file/file_system.h:76:20: error: expected unqualified-id
typedef std::vector<CFileInfo> CFileInfos;
                   ^
../../../source/lib/file/file_system.h:77:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<OsPath> DirectoryNames;
        ~~~~~^
../../../source/lib/file/file_system.h:77:20: error: expected unqualified-id
typedef std::vector<OsPath> DirectoryNames;
                   ^
In file included from ../../../source/lib/file/archive/archive_zip.cpp:28:
In file included from ../../../source/lib/file/archive/archive_zip.h:30:
In file included from ../../../source/lib/file/archive/archive.h:30:
../../../source/lib/file/file_system.h:76:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<CFileInfo> CFileInfos;
        ~~~~~^
../../../source/lib/file/file_system.h:76:20: error: expected unqualified-id
typedef std::vector<CFileInfo> CFileInfos;
                   ^
../../../source/lib/file/file_system.h:79:56: error: unknown type name 'CFileInfos'; did you mean 'CFileInfo'?
LIB_API Status GetDirectoryEntries(const OsPath& path, CFileInfos* files, DirectoryNames* subdirectoryNames);
                                                       ^~~~~~~~~~
                                                       CFileInfo
../../../source/lib/file/file_system.h:41:7: note: 'CFileInfo' declared here
class CFileInfo
      ^
../../../source/lib/file/file_system.h:77:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<OsPath> DirectoryNames;
        ~~~~~^
../../../source/lib/file/file_system.h:77:20: error: expected unqualified-id
typedef std::vector<OsPath> DirectoryNames;
                   ^
../../../source/lib/file/file_system.h:79:75: error: unknown type name 'DirectoryNames'
LIB_API Status GetDirectoryEntries(const OsPath& path, CFileInfos* files, DirectoryNames* subdirectoryNames);
                                                                          ^
../../../source/lib/file/file_system.h:79:56: error: unknown type name 'CFileInfos'; did you mean 'CFileInfo'?
LIB_API Status GetDirectoryEntries(const OsPath& path, CFileInfos* files, DirectoryNames* subdirectoryNames);
                                                       ^~~~~~~~~~
                                                       CFileInfo
../../../source/lib/file/file_system.h:41:7: note: 'CFileInfo' declared here
class CFileInfo
      ^
../../../source/lib/file/file_system.h:79:75: error: unknown type name 'DirectoryNames'
LIB_API Status GetDirectoryEntries(const OsPath& path, CFileInfos* files, DirectoryNames* subdirectoryNames);
                                                                          ^
6 errors generated.
make[1]: *** [obj/lowlevel_Debug/archive.o] Error 1
make[1]: *** Waiting for unfinished jobs....
6 errors generated.
make[1]: *** [obj/lowlevel_Debug/archive_zip.o] Error 1
make: *** [lowlevel] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2089/display/redirect

wraitii updated this revision to Diff 14160.Mon, Nov 23, 9:57 AM

More includes for the header god

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3189/display/redirect

Angen added a subscriber: Angen.Mon, Nov 23, 10:31 AM
Angen added inline comments.
source/network/NetServer.h
355

something broke, from jenkins windows

network\NetServer.h(354): error C2039: 'time_t': is not a member of 'std' (compiling source file ..\..\..\source\network\NetServer.cpp)
wraitii added inline comments.Mon, Nov 23, 10:36 AM
source/network/NetServer.h
355

Fixed in the latest diff. I needed to include <ctime>

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface_dbg.a(precompiled.o) has no symbols
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/lib/file/common/real_directory.cpp:24:
In file included from ../../../source/lib/file/common/real_directory.h:27:
../../../source/lib/sysdep/dir_watch.h:84:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<DirWatchNotification> DirWatchNotifications;
        ~~~~~^
../../../source/lib/sysdep/dir_watch.h:84:20: error: expected unqualified-id
typedef std::vector<DirWatchNotification> DirWatchNotifications;
                   ^
../../../source/lib/sysdep/dir_watch.h:99:31: error: unknown type name 'DirWatchNotifications'
LIB_API Status dir_watch_Poll(DirWatchNotifications& notifications);
                              ^
3 errors generated.
make[1]: *** [obj/lowlevel_Debug/real_directory.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [lowlevel] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2090/display/redirect

wraitii updated this revision to Diff 14164.Mon, Nov 23, 11:14 AM

Fix filesystem

wraitii added inline comments.Mon, Nov 23, 11:16 AM
source/lib/file/file_system.h
33

this one I should be able to replace with a forward declare

source/lib/file/vfs/vfs_path.h
29

this one I should be able to replace with a forward declare

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3193/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/ps/Filesystem.cpp:25:
../../../source/lib/sysdep/dir_watch.h:41:14: error: no type named 'shared_ptr' in namespace 'std'
typedef std::shared_ptr<DirWatch> PDirWatch;
        ~~~~~^
../../../source/lib/sysdep/dir_watch.h:41:24: error: expected unqualified-id
typedef std::shared_ptr<DirWatch> PDirWatch;
                       ^
../../../source/lib/sysdep/dir_watch.h:60:50: error: unknown type name 'PDirWatch'; did you mean 'DirWatch'?
LIB_API Status dir_watch_Add(const OsPath& path, PDirWatch& dirWatch);
                                                 ^~~~~~~~~
                                                 DirWatch
../../../source/lib/sysdep/dir_watch.h:40:8: note: 'DirWatch' declared here
struct DirWatch;
       ^
../../../source/lib/sysdep/dir_watch.h:92:14: error: no type named 'vector' in namespace 'std'; did you mean 'hecto'?
typedef std::vector<DirWatchNotification> DirWatchNotifications;
        ~~~~~^~~~~~
             hecto
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/ratio:268:43: note: 'hecto' declared here
typedef ratio<                100LL, 1LL> hecto;
                                          ^
In file included from ../../../source/ps/Filesystem.cpp:25:
../../../source/lib/sysdep/dir_watch.h:92:20: error: expected unqualified-id
typedef std::vector<DirWatchNotification> DirWatchNotifications;
                   ^
../../../source/lib/sysdep/dir_watch.h:107:31: error: unknown type name 'DirWatchNotifications'
LIB_API Status dir_watch_Poll(DirWatchNotifications& notifications);
                              ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:65:38: error: reference to 'vector' is ambiguous
  template<> struct is_pathable<std::vector<char> >     { static const bool value = true; };
                                ~~~~~^
../../../source/lib/sysdep/dir_watch.h:34:8: note: candidate found by name lookup is 'std::vector'
        class vector;
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1244:75: note: candidate found by name lookup is 'std::__1::vector'
    template <class _Tp, class _Alloc> friend class _LIBCPP_TYPE_VIS_ONLY vector;
                                                                          ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:65:38: error: unknown type name 'vector'; did you mean 'mozilla::Vector'?
  template<> struct is_pathable<std::vector<char> >     { static const bool value = true; };
                                     ^
/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/Vector.h:281:7: note: 'mozilla::Vector' declared here
class Vector final : private AllocPolicy
      ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:66:38: error: reference to 'vector' is ambiguous
  template<> struct is_pathable<std::vector<wchar_t> >  { static const bool value = true; };
                                ~~~~~^
../../../source/lib/sysdep/dir_watch.h:34:8: note: candidate found by name lookup is 'std::vector'
        class vector;
              ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:1244:75: note: candidate found by name lookup is 'std::__1::vector'
    template <class _Tp, class _Alloc> friend class _LIBCPP_TYPE_VIS_ONLY vector;
                                                                          ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:66:38: error: unknown type name 'vector'; did you mean 'mozilla::Vector'?
  template<> struct is_pathable<std::vector<wchar_t> >  { static const bool value = true; };
                                     ^
/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/Vector.h:281:7: note: 'mozilla::Vector' declared here
class Vector final : private AllocPolicy
      ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:239:30: error: no type named 'vector' in namespace 'std'; did you mean 'hecto'?
    void dispatch(const std::vector<char>& c, U& to, const codecvt_type& cvt)
                        ~~~~~^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/ratio:268:43: note: 'hecto' declared here
typedef ratio<                100LL, 1LL> hecto;
                                          ^
In file included from ../../../source/ps/Filesystem.cpp:28:
In file included from ../../../libraries/osx/boost/include/boost/filesystem.hpp:16:
In file included from ../../../libraries/osx/boost/include/boost/filesystem/path.hpp:25:
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:239:36: error: expected ')'
    void dispatch(const std::vector<char>& c, U& to, const codecvt_type& cvt)
                                   ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:239:18: note: to match this '('
    void dispatch(const std::vector<char>& c, U& to, const codecvt_type& cvt)
                 ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:241:9: error: use of undeclared identifier 'c'
    if (c.size())
        ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:242:17: error: use of undeclared identifier 'c'
      convert(&*c.begin(), &*c.begin() + c.size(), to, cvt);
                ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:242:30: error: use of undeclared identifier 'c'
      convert(&*c.begin(), &*c.begin() + c.size(), to, cvt);
                             ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:242:42: error: use of undeclared identifier 'c'
      convert(&*c.begin(), &*c.begin() + c.size(), to, cvt);
                                         ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:242:52: error: use of undeclared identifier 'to'
      convert(&*c.begin(), &*c.begin() + c.size(), to, cvt);
                                                   ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:242:56: error: use of undeclared identifier 'cvt'
      convert(&*c.begin(), &*c.begin() + c.size(), to, cvt);
                                                       ^
../../../libraries/osx/boost/include/boost/filesystem/path_traits.hpp:245:30: error: no type named 'vector' in namespace 'std'; did you mean 'hecto'?
    void dispatch(const std::vector<wchar_t>& c, U& to, const codecvt_type& cvt)
                        ~~~~~^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/ratio:268:43: note: 'hecto' declared here
typedef ratio<                100LL, 1LL> hecto;
                                          ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[1]: *** [obj/engine_Debug/Filesystem.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [engine] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2093/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
In file included from ../../../source/ps/Filesystem.cpp:25:0:
../../../source/lib/sysdep/dir_watch.h:34:8: error: redeclared with 1 template parameter
  class vector;
        ^~~~~~
In file included from /usr/local/include/c++/6.5.0/vector:64:0,
                 from ../../../source/lib/pch/pch_stdlib.h:58,
                 from ../../../source/lib/precompiled.h:106,
                 from ../../../source/pch/engine/precompiled.h:18:
/usr/local/include/c++/6.5.0/bits/stl_vector.h:214:11: note: previous declaration 'template<class _Tp, class _Alloc> class std::vector' used 2 template parameters
     class vector : protected _Vector_base<_Tp, _Alloc>
           ^~~~~~
make[1]: *** [obj/engine_Debug/Filesystem.o] Error 1
make: *** [engine] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3750/display/redirect

wraitii updated this revision to Diff 14171.Tue, Nov 24, 9:15 AM

Remove the forward declaration which didn't work out as I'd hoped.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
../../../source/simulation2/scripting/JSInterface_Simulation.cpp:154:4: warning: suggest braces around initialization of subobject [-Wmissing-braces]
                        CFixedVector2D(-halfSize.X, -halfSize.Y),
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface_dbg.a(precompiled.o) has no symbols
../../../source/third_party/fmt/format.cpp:145:7: warning: '_POSIX_C_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
      ^
../../../source/third_party/fmt/format.cpp:145:37: warning: '_XOPEN_SOURCE' is not defined, evaluates to 0 [-Wundef]
#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || (defined(__ANDROID__) && __ANDROID__)
                                    ^
2 warnings generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
In file included from ../../../source/lib/sysdep/acpi.cpp:30:
../../../source/lib/sysdep/os/win/wfirmware.h:31:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<TableId> TableIds;
        ~~~~~^
../../../source/lib/sysdep/os/win/wfirmware.h:31:20: error: expected unqualified-id
typedef std::vector<TableId> TableIds;
                   ^
../../../source/lib/sysdep/os/win/wfirmware.h:33:8: error: unknown type name 'TableIds'; did you mean 'TableId'?
extern TableIds GetTableIDs(Provider provider);
       ^~~~~~~~
       TableId
../../../source/lib/sysdep/os/win/wfirmware.h:30:13: note: 'TableId' declared here
typedef u32 TableId;
            ^
../../../source/lib/sysdep/os/win/wfirmware.h:35:14: error: no type named 'vector' in namespace 'std'
typedef std::vector<u8> Table;
        ~~~~~^
../../../source/lib/sysdep/os/win/wfirmware.h:35:20: error: expected unqualified-id
typedef std::vector<u8> Table;
                   ^
../../../source/lib/sysdep/os/win/wfirmware.h:37:8: error: unknown type name 'Table'
extern Table GetTable(Provider provider, TableId tableId);
       ^
../../../source/lib/sysdep/acpi.cpp:111:19: error: no type named 'TableIds' in namespace 'wfirmware'; did you mean 'TableId'?
        const wfirmware::TableIds tableIDs = wfirmware::GetTableIDs(provider);
              ~~~~~~~~~~~^~~~~~~~
                         TableId
../../../source/lib/sysdep/os/win/wfirmware.h:30:13: note: 'TableId' declared here
typedef u32 TableId;
            ^
../../../source/lib/sysdep/acpi.cpp:113:22: error: member reference base type 'const wfirmware::TableId' (aka 'const unsigned int') is not a structure or union
        numTables = tableIDs.size();
                    ~~~~~~~~^~~~~
../../../source/lib/sysdep/acpi.cpp:118:20: error: use of undeclared identifier 'table'; did you mean 'tables'?
                wfirmware::Table table = wfirmware::GetTable(provider, tableIDs[i]);
                                 ^~~~~
                                 tables
../../../source/lib/sysdep/acpi.cpp:108:54: note: 'tables' declared here
static void AllocateAndCopyTables(const AcpiTable**& tables, size_t& numTables)
                                                     ^
../../../source/lib/sysdep/acpi.cpp:118:19: error: expected ';' after expression
                wfirmware::Table table = wfirmware::GetTable(provider, tableIDs[i]);
                                ^
                                ;
../../../source/lib/sysdep/acpi.cpp:118:3: error: no member named 'Table' in namespace 'wfirmware'; did you mean 'tables'?
                wfirmware::Table table = wfirmware::GetTable(provider, tableIDs[i]);
                ^~~~~~~~~~~~~~~~
                tables
../../../source/lib/sysdep/acpi.cpp:108:54: note: 'tables' declared here
static void AllocateAndCopyTables(const AcpiTable**& tables, size_t& numTables)
                                                     ^
../../../source/lib/sysdep/acpi.cpp:118:66: error: subscripted value is not an array, pointer, or vector
                wfirmware::Table table = wfirmware::GetTable(provider, tableIDs[i]);
                                                                       ~~~~~~~~^~
../../../source/lib/sysdep/acpi.cpp:119:11: error: use of undeclared identifier 'table'
                ENSURE(!table.empty());
                        ^
../../../source/lib/sysdep/acpi.cpp:120:29: error: use of undeclared identifier 'table'
                tables[i] = AllocateTable(table.size());
                                          ^
../../../source/lib/sysdep/acpi.cpp:121:29: error: use of undeclared identifier 'table'
                memcpy((void*)tables[i], &table[0], table.size());
                                          ^
../../../source/lib/sysdep/acpi.cpp:121:39: error: use of undeclared identifier 'table'
                memcpy((void*)tables[i], &table[0], table.size());
                                                    ^
../../../source/lib/sysdep/acpi.cpp:118:14: warning: expression result unused [-Wunused-value]
                wfirmware::Table table = wfirmware::GetTable(provider, tableIDs[i]);
                           ^~~~~
1 warning and 16 errors generated.
make[1]: *** [obj/lowlevel_Debug/acpi.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [lowlevel] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2099/display/redirect