Add function to get OpenGL error name by the code
ClosedPublic
Actions

Authored by vladislavbelov on Apr 10 2017, 2:02 PM.

Details

Reviewers

elexis
wraitii

Commits

rP19496: Print the name of OpenGL errors when they occur.

Trac Tickets

#4344

Summary

We need sometimes to print GL error name. I.e. #3996: Renderer just print the error code instead of user-friendly message.

Current ogl_WarnIfErrorLoc doesn't show the text message, only the code in the console. Also it uses debug_printf instead of LOGWARNING or LOGERROR.

Test Plan

Run the game in window mode
Resize window in any unusual values
It produces a renderer error about endframe

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Apr 10 2017, 2:02 PM

vladislavbelov edited the test plan for this revision. (Show Details)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/733/ for more details.

Harbormaster completed remote builds in B1076: Diff 1193.Apr 10 2017, 2:59 PM

wraitii accepted this revision.Apr 30 2017, 10:17 AM

This revision is now accepted and ready to land.Apr 30 2017, 10:17 AM

Closed by commit rP19496: Print the name of OpenGL errors when they occur. (authored by wraitii). · Explain WhyMay 1 2017, 9:19 AM

This revision was automatically updated to reflect the committed changes.