Page MenuHomeWildfire Games

Enable other languages than English in the Windows installer
ClosedPublic

Authored by vladislavbelov on Apr 10 2017, 2:15 PM.

Details

Summary

Adds the language selection on startup. Old NSIS doesn't support the Unicode and some languages from the list, so the patched version should be built with NSIS >= 3.0.

All languages below are supported by the current version of NSIS, but other languages should be translated manually, and it's more complex work, because it needs an integration with Transifex, new scripts for adaptation, etc. So if we want other languages too it should be in separated proposal with designer discussion.

Test Plan

Caution! May take amount of time.

  1. Build install file
  2. Run it and check that there is a language selection
  3. Test the game runs after installation

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Apr 10 2017, 2:15 PM
vladislavbelov edited the summary of this revision. (Show Details)Apr 10 2017, 2:24 PM
Vulcan added a subscriber: Vulcan.Apr 10 2017, 2:59 PM

Build has FAILED

Link to build: http://jw:8080/job/phabricator/734/
See console output for more information: http://jw:8080/job/phabricator/734/console

Itms requested changes to this revision.Apr 10 2017, 6:27 PM

That's cool! I can test it in a few days, when I have the time to run a bundling.

In the meantime I think the set of included languages should be the same as the set of officially supported languages in-game. Else, people might be disappointed when the installer was in their language and the game is not.
Can you change that? ๐Ÿ™‚

This revision now requires changes to proceed.Apr 10 2017, 6:27 PM
vladislavbelov edited edge metadata.

Intersected with Transifex languages.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/741/ for more details.

Imarok edited edge metadata.Apr 19 2017, 11:23 AM

How to test this on win?

In D314#14242, @Imarok wrote:

How to test this on win?

You have to install NSIS 3+, then run source/tools/dist/0ad.nsi with it.
Also there is an example for Linux.

Itms added a comment.May 1 2017, 5:13 PM

Intersected with Transifex languages.

I'm very sorry there was a misunderstanding. The Transifex languages are not the interesting ones, we only want the languages that are bundled in the release versions! You can get the list here: https://trac.wildfiregames.com/browser/ps/trunk/source/tools/i18n/creditTranslators.py#L35

Some comments in the related files would be nice so this list keeps getting updated in case the languages change.

source/tools/dist/0ad.nsi
98 โ†—(On Diff #1591)

You want Slovak, as we have "sk" in that other file, not "sl".

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/959/ for more details.

vladislavbelov added inline comments.May 2 2017, 12:54 AM
source/tools/dist/0ad.nsi
98 โ†—(On Diff #1591)

True, Slovak.

vladislavbelov marked an inline comment as done.May 2 2017, 1:03 AM
Vulcan added a comment.May 2 2017, 1:48 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/960/ for more details.

Itms accepted this revision.May 7 2017, 4:36 PM
This revision is now accepted and ready to land.May 7 2017, 4:36 PM
This revision was automatically updated to reflect the committed changes.