Page MenuHomeWildfire Games

Fix copy pasting in console.
AbandonedPublic

Authored by Stan on Nov 27 2020, 4:33 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Currently you cannot copy paste in the console, because the events are mangled by the Hotkeys this patch fixes that

Test Plan

Try copy pasting in the console.

Unit TestsFailed

TimeTest
0 msJenkins > cxxtest_debug.xml::[failed-to-read]
Failed to read test report file E:\Jenkins\workspace\vs2015-differential\cxxtest_debug.xml org.dom4j.DocumentException: Error on line 435 of document : Content is not allowed in trailing section. at org.dom4j.io.SAXReader.read(SAXReader.java:511)
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAllocators::test_da
0 msJenkins > TestAtlasObjectXML::test_parse_attributes1
View Full Test Results (1 Failed · 1,021 Passed)

Event Timeline

Stan created this revision.Nov 27 2020, 4:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
In file included from ../../../source/network/NetClientTurnManager.cpp:20:
In file included from ../../../source/network/NetClientTurnManager.h:21:
In file included from ../../../source/simulation2/system/TurnManager.h:22:
In file included from ../../../source/simulation2/helpers/SimulationCommand.h:21:
../../../source/scriptinterface/ScriptTypes.h:62:10: fatal error: 'jspubtd.h' file not found
#include "jspubtd.h"
         ^~~~~~~~~~~
In file included from ../../../source/network/NetHost.cpp:23:
In file included from ../../../source/network/NetMessage.h:26:
In file included from ../../../source/network/NetMessages.h:27:
../../../source/scriptinterface/ScriptTypes.h:62:10: fatal error: 'jspubtd.h' file not found
#include "jspubtd.h"
         ^~~~~~~~~~~
In file included from ../../../source/network/NetFileTransfer.cpp:23:
In file included from ../../../source/network/NetMessage.h:26:
In file included from ../../../source/network/NetMessages.h:27:
../../../source/scriptinterface/ScriptTypes.h:62:10: fatal error: 'jspubtd.h' file not found
#include "jspubtd.h"
         ^~~~~~~~~~~
1 error generated.
make[1]: *** [obj/network_Debug/NetHost.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 error generated.
make[1]: *** [obj/network_Debug/NetFileTransfer.o] Error 1
In file included from ../../../source/network/NetClient.cpp:20:
In file included from ../../../source/network/NetClient.h:24:
In file included from ../../../source/scriptinterface/ScriptInterface.h:25:
../../../source/scriptinterface/ScriptTypes.h:62:10: fatal error: 'jspubtd.h' file not found
#include "jspubtd.h"
         ^~~~~~~~~~~
1 error generated.
make[1]: *** [obj/network_Debug/NetClientTurnManager.o] Error 1
1 error generated.
make[1]: *** [obj/network_Debug/NetClient.o] Error 1
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2163/display/redirect

Stan requested review of this revision.Nov 27 2020, 5:32 PM
vladislavbelov added inline comments.
source/ps/CConsole.cpp
98

Why so? We use space after // according to CC.

638

I suppose you don't plan to change a value of type.

639

Seems a bit strange, because you pass type != SDL_HOTKEYPRESS only for the visibility toggle. You might enable it here.

647

Reference on what? It's not a std::string_view.

673–676

Why that? And why not others?

699

Shouldn't it catch all events if it's a console?

source/ps/Hotkey.cpp
233

Seems useless.

Stan abandoned this revision.Jun 11 2021, 5:43 PM
Stan marked 2 inline comments as done.

Was fixed between A24 and A25