Page MenuHomeWildfire Games

[SM78] build system changes
ClosedPublic

Authored by wraitii on Nov 30 2020, 11:07 AM.

Details

Summary

These are the build system changes for SM78.
It's mostly the same as SM68, except rust is actually usde by SM.

See https://github.com/wraitii/0ad/tree/sm78

Test Plan

Compile.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Nov 30 2020, 11:07 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2191/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3287/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3857/display/redirect

wraitii requested review of this revision.Nov 30 2020, 2:45 PM
Freagarach added inline comments.
build/premake/extern_libs5.lua
589 ↗(On Diff #14288)

Did I say variable before?

616 ↗(On Diff #14288)

?

libraries/source/spidermonkey/build.sh
57 ↗(On Diff #14288)

If you don't add anything, you don't need this ;)

wraitii updated this revision to Diff 14380.Dec 4 2020, 9:13 AM

Update to HEAD

Owners added a subscriber: Restricted Owners Package.Dec 4 2020, 9:13 AM
Vulcan added a comment.Dec 4 2020, 9:21 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3357/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc7.txt
In file included from ../../../source/lib/precompiled.h:74,
                 from ../../../source/pch/simulation2/precompiled.h:19:
../../../source/simulation2/components/CCmpAIManager.cpp: In member function 'void CAIWorker::UpdatePathfinder(const Grid<short unsigned int>&, bool, const Grid<unsigned char>&, bool, const std::map<std::__cxx11::basic_string<char>, short unsigned int>&, const std::map<std::__cxx11::basic_string<char>, short unsigned int>&)':
../../../source/simulation2/components/CCmpAIManager.cpp:560:11: error: 'JS_GetArrayLength' was not declared in this scope
    ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
           ^~~~~~~~~~~~~~~~~
../../../source/lib/debug.h:295:8: note: in definition of macro 'ENSURE'
   if(!(expr))\
        ^~~~
../../../source/simulation2/components/CCmpAIManager.cpp:560:11: note: suggested alternative: 'JS_GetTypedArrayLength'
    ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
           ^~~~~~~~~~~~~~~~~
../../../source/lib/debug.h:295:8: note: in definition of macro 'ENSURE'
   if(!(expr))\
        ^~~~
../../../source/simulation2/components/CCmpAIManager.cpp: In member function 'void CAIWorker::UpdateTerritoryMap(const Grid<unsigned char>&)':
../../../source/simulation2/components/CCmpAIManager.cpp:588:11: error: 'JS_GetArrayLength' was not declared in this scope
    ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
           ^~~~~~~~~~~~~~~~~
../../../source/lib/debug.h:295:8: note: in definition of macro 'ENSURE'
   if(!(expr))\
        ^~~~
../../../source/simulation2/components/CCmpAIManager.cpp:588:11: note: suggested alternative: 'JS_GetTypedArrayLength'
    ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
           ^~~~~~~~~~~~~~~~~
../../../source/lib/debug.h:295:8: note: in definition of macro 'ENSURE'
   if(!(expr))\
        ^~~~
make[1]: *** [simulation2.make:248: obj/simulation2_Debug/CCmpAIManager.o] Error 1
make: *** [Makefile:107: simulation2] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3927/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
../../../source/simulation2/components/CCmpAIManager.cpp:560:11: error: use of undeclared identifier 'JS_GetArrayLength'
                        ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
                               ^
../../../source/simulation2/components/CCmpAIManager.cpp:588:11: error: use of undeclared identifier 'JS_GetArrayLength'
                        ENSURE(JS_GetArrayLength(rq.cx, dataObj, &length));
                               ^
2 errors generated.
make[1]: *** [obj/simulation2_Debug/CCmpAIManager.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [simulation2] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2263/display/redirect

SM Builds for me. Lubuntu 18.04.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2020, 3:12 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.