Page MenuHomeWildfire Games

Proper disabled lobby account registration notification
ClosedPublic

Authored by elexis on Apr 11 2017, 8:24 PM.

Details

Summary

If the lobby account creation was disabled by us for any reason, players see the string
This client has insufficient permissions to remove an account which is counterproductive.
If it was disabled, people should be tought that it actually was disabled, otherwise they will spam the forums asking what that error means.

In rP17587 fixing #3047 the "Registration forbidden" string was changed to the current one.

Test Plan

Should we also state that they should retry in the upcoming days or just stick with the facts?

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Apr 11 2017, 8:24 PM
elexis edited the summary of this revision. (Show Details)Apr 11 2017, 8:25 PM
scythetwirler edited edge metadata.Apr 11 2017, 8:25 PM

Why not just "Registration Forbidden"?

elexis edited the summary of this revision. (Show Details)Apr 11 2017, 8:25 PM

Forbidden could also mean that it just affects that one person, while "currently disabled" attempts to state something about the lobby server in it's entirety

scythetwirler accepted this revision.Apr 11 2017, 8:33 PM
This revision is now accepted and ready to land.Apr 11 2017, 8:33 PM
Vulcan added a subscriber: Vulcan.Apr 11 2017, 9:09 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/747/ for more details.

In D319#12448, @elexis wrote:

Forbidden could also mean that it just affects that one person,

Which it could also be, if registration is only allowed for some ip ranges or similar.

elexis planned changes to this revision.Apr 12 2017, 12:51 PM
In D319#12454, @leper wrote:
In D319#12448, @elexis wrote:

Forbidden could also mean that it just affects that one person,

Which it could also be, if registration is only allowed for some ip ranges or similar.

Well, you are right, there is the ip_access field in ejabberd that denies registration from IP ranges:
https://docs.ejabberd.im/admin/configuration/#mod-register

Currently ejabberd returns only the legacy code 403 without a textual explanaiton, so there's nothing to improve in gloox.
https://xmpp.org/extensions/xep-0086.html

The access_from, captcha_protected and password_strength options also look like they would return that code.

Couldn't find any exact statements in the specs when that code is returned, so I assume the server can decide freely when it returns that code.

Therefore it should indeed be reverted to the old "Registration Forbidden" string.

While at it should also review the other string changes at the time.

This revision was automatically updated to reflect the committed changes.