Setting gui.scale != 1.0 causes the bandbox to appear in a wrong location.
elexis domdomegg mimo
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- rP19411: Fix in-game bandbox when gui.scale is not 1
- Trac Tickets
Applying the scale to the bandbox size the problem is fixed, as it can be seen inside the game
Patch looks correct, but you should add an entry to programming.json, with or without your realname.
Also could you check/imagine whether there are similar things missing somewhere else?
Tested on 4K screen on Ubuntu 16.04 with gui.scale = 0.5, 0.75 and 1, bandbox now actually matches up in all three cases (previously only when gui.scale = 1).
All relevant automated tests pass (it's an extremely minor change so would be amazed if they didn't).
Thanks for the patch and the reviews. (Remember programming.json entry should be committed with the first patch of the author, as we want to avoid committed contributions without contributor entries)
Feel free to update programming.json if that prevents you from sleeping, but honestly i start to be tired of people thinking they have to rule everything.
Darios explicitely said he doesn't care and can wait for D320, which as could be seen from the comments, i had started to look at and would have been commited soon. But i think i will leave it to you now, so you won't have to do any such comments.