Page MenuHomeWildfire Games

Move the 'user' mod into a separate path.
Needs ReviewPublic

Authored by wraitii on Dec 12 2020, 10:08 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

The 'user' mod, from #1940, is intended to be an always-writable location for, in particular, atlas maps, and other user data.
It is not really a 'mod', since it doesn't have a a mod.json and can't be 'not loaded' (NB: there is a command line flag, but that's hacky at best).

The problem of knowing where to write files is difficult. See https://code.wildfiregames.com/rP13472#43581
Given that we can have many mods loaded, we can write to a bunch of different locations (/ with D3217, we'd write to the highest priority mod). This is not necessarily obviously better, given that a map made with multiple mods might not be particularly compatible with only one mode.

Ergo, I'd suggest keeping this 'user' mod, but moving it ouf of 'mods', and into '[userpath]/userdata'. This makes it less weird, and removes one name from there.
The concept of "dev copy" should probably be reworked, possibly having a configure option to activate it for modders would be useful.

Test Plan

Agree with the above

Event Timeline

wraitii created this revision.Dec 12 2020, 10:08 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2412/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4074/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3500/display/redirect

wraitii requested review of this revision.Dec 12 2020, 11:22 PM
vladislavbelov added inline comments.
source/ps/GameSetup/GameSetup.cpp
417–419

The naming seems strange, you put userdata in userdata.

wraitii added inline comments.Dec 15 2020, 12:30 PM
source/ps/GameSetup/GameSetup.cpp
417–419

Mh, fair.
I suppose I could just name it data/. Would make more sense if mods were all namespace under a common path.