Page MenuHomeWildfire Games
Differential D3278

UnitAI walk orders: stop trying only when very obstructed.
Changes PlannedPublic
Actions

Authored by wraitii on Jan 2 2021, 11:27 AM.

Details

Reviewers
None
Summary

Follows D3209
One can now use the 'very obstructed' message, which indicates a unit is quite stuck. The 'relaxed range check' can use this to try harder to reach the target point.
I still relax on 'obstructed', which comes much faster, if there are additional orders after, as that improves behaviour.

Test Plan

Order 30 units to move to a single point (not in formation). Compare.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
temp
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:342ESLintBear (consistent-return)ESLintBear (consistent-return)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:785ESLintBear (no-else-return)ESLintBear (no-else-return)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:2148ESLintBear (operator-linebreak)ESLintBear (operator-linebreak)
Unit
No Unit Test Coverage
Build Status
Buildable 14997
Build 32400: Vulcan BuildJenkins
Build 32399: Vulcan Build (macOS)
Build 32398: Vulcan Build (Windows)Jenkins
Build 32397: arc lint + arc unit

Event Timeline

wraitii created this revision.Jan 2 2021, 11:27 AM
Vulcan added a comment.Jan 2 2021, 11:36 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2646/display/redirect

Vulcan added a comment.Jan 2 2021, 11:38 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3738/display/redirect

Vulcan added a comment.Jan 2 2021, 11:53 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4309/display/redirect

Harbormaster completed remote builds in B14696: Diff 14946.Jan 2 2021, 11:53 AM
wraitii requested review of this revision.Jan 2 2021, 11:53 AM
wraitii updated this revision to Diff 15250.Jan 13 2021, 2:01 PM

Rebased. Planning to merge still as the current behaviour can look buggy, even if it's not really problematic.

Freagarach added a subscriber: Freagarach.EditedJan 13 2021, 3:40 PM

Looks relatively safe.

Freagarach added a comment.Jan 13 2021, 3:44 PM

Although I have to say that I do not see the need and it merely adds pathfinder strain. IMHO.

wraitii added a comment.Jan 13 2021, 3:47 PM
In D3278#148874, @Freagarach wrote:

Although I have to say that I do not see the need and it merely adds pathfinder strain. IMHO.

If you take a bunch of units and order them to move (not in formation) to a point, they can occasionally stop 8 meters away (or not even move at all). This looks odd.

Freagarach added a comment.Jan 13 2021, 4:19 PM

I know, but how often do you want them to be at exactly that position?

wraitii added a comment.Jan 13 2021, 4:27 PM
In D3278#148895, @Freagarach wrote:

I know, but how often do you want them to be at exactly that position?

Dunno :P
I guess you've convinced me to not merge this for A24.

wraitii planned changes to this revision.Mar 18 2021, 12:04 PM

I think I'll still want this, but probably not before Unit Pushing is merged / might be irrelevant then.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
components/
12 lines

Diff 15250

View Options

binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
Wildfire Games · Phabricator