Page MenuHomeWildfire Games

Fix FreeBSD compilation of SpiderMonkey
ClosedPublic

Authored by Stan on Mon, Jan 4, 10:33 AM.

Details

Summary

Title

Test Plan

Test compilation and report back

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Mon, Jan 4, 10:33 AM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/StaticAnalysisFunctions.h' has been modified since the precompiled header 'obj/network_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/network_Debug/precompiled.h.gch'
1 error generated.
make[1]: *** [obj/network_Debug/NetMessageSim.o] Error 1
make: *** [network] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2666/display/redirect

Stan requested review of this revision.Mon, Jan 4, 2:43 PM
Stan updated this revision to Diff 15002.Tue, Jan 5, 12:59 PM

Fix patch, ignore debug build on spidermonkey for now

Are these patches upstreamed?

Stan updated this revision to Diff 15390.Sat, Jan 16, 5:19 PM

Fix bug when the repository is clean and one of the folder has not been created

Build has FAILED

builderr-debug-macos.txt
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/RefPtr.h' has been modified since the precompiled header 'obj/test_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/test_Debug/precompiled.h.gch'
1 error generated.
make[1]: *** [obj/test_Debug/test_root.o] Error 1
make: *** [test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2898/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2898/display/redirectconsole

These look fine to me and I am including these in the test port I've made. With these patches I ma able to compile a binary.

I still have to run test it though, due to problems with installing data files correctly.. The binary starts but fails to find required datafiles and bails out.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Jan 17, 4:55 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.