Page MenuHomeWildfire Games

[gui] tweak civ overview column widths
ClosedPublic

Authored by Nescio on Jan 5 2021, 12:28 PM.

Details

Reviewers
s0600204
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24611: Adjust subsection sizes of civinfo page
Summary

This is how the civilization overviews currently look:


As you can see each of the columns has a different width, which looks a bit ugly. Furthermore, the third column displays both technologies, which has the most items (see e.g. pers), and structures, which can have many items too (see e.g. kush); scrollbars are ugly, especially when there is free empty space available elsewhere; by contrast, all civs have three hero entries, which doesn't take up much space vertically. Moreover, units and structures are both entities and thus conceptually more similar to each other than to technologies.
This patch resizes the columns to a width of 32% each and moves the structures to the third column:

(Having four columns looked bad, they became too narrow.)

Test Plan

Have a critical look at both the current and proposed situations, then decided what looks best.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 5 2021, 12:28 PM
Owners added a subscriber: Restricted Owners Package.Jan 5 2021, 12:28 PM
Stan edited the summary of this revision. (Show Details)Jan 5 2021, 12:47 PM

Aye, looks better :)

Nescio requested review of this revision.Jan 6 2021, 10:11 AM
s0600204 added a comment.EditedJan 14 2021, 7:49 AM

Now that civ-specific structures have been restored to the page - and thus there's more text in the civStructures subsection - do you remain happy with the subsection sizes you've chosen?

Yes, I had D2733 in mind when writing this patch. I tried different arrangements and these numbers looked best to me. The improvement is especially noticeable for the Kushites (who have five specific structures) and Persians (who have a lot of technologies); with this patch applied there are no longer scrollbars for those two; only for Carthage (due to the long super dock tooltip) now.

s0600204 accepted this revision.Jan 14 2021, 10:30 AM

Fair enough. (Didn't want to commit it and then find out you wanted to adjust it to compensate ๐Ÿ˜‰.)

This revision is now accepted and ready to land.Jan 14 2021, 10:30 AM
This revision was landed with ongoing or failed builds.Jan 14 2021, 11:57 PM
This revision was automatically updated to reflect the committed changes.