Some cleaning in input.js.
ClosedPublic
Actions

Authored by Freagarach on Jan 7 2021, 11:13 AM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP24537: Some cleaning in input.js.

Summary

var -> let
Linter issues (except default cases for switches).
Delete unused comments.
Removed some trailing commas in objects.

Test Plan

Check for improvements, verify unmodified behaviour.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Jan 7 2021, 11:13 AM

Owners added a subscriber: Restricted Owners Package.Jan 7 2021, 11:13 AM

Freagarach added inline comments.Jan 7 2021, 11:14 AM

binaries/data/mods/public/gui/session/input.js
241 ↗	(On Diff #15037)	rP15336

Build has FAILED

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3798/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/vs2015-differential/3798/display/redirectconsole

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file

See https://jenkins.wildfiregames.com/job/macos-differential/2706/display/redirect for more details.

Harbormaster completed remote builds in B14775: Diff 15037.Jan 7 2021, 11:33 AM

Freagarach requested review of this revision.Jan 7 2021, 11:33 AM

Stan awarded a token.Jan 7 2021, 11:42 AM

Freagarach added inline comments.Jan 10 2021, 8:48 AM