Page MenuHomeWildfire Games
Differential D3302

Upgrade ship_movement_speed / tower_health icons
ClosedPublic
Actions

Authored by borg- on Jan 8 2021, 1:34 AM.

Details

Reviewers
wraitii
Commits
rP24737: Upgrade ship_movement_speed / tower_health icons
Summary

Most of the icons have already been updated, only these two in my view need a change.

Test Plan

Agree that it is a improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

borg- requested review of this revision.Jan 8 2021, 1:34 AM
borg- created this revision.
borg- edited the summary of this revision. (Show Details)
borg- added a subscriber: wowgetoffyourcellphone.
borg- updated this revision to Diff 15050.Jan 8 2021, 2:02 AM
borg- edited the summary of this revision. (Show Details)
asterix awarded a token.Jan 8 2021, 10:27 AM
borg- updated this revision to Diff 15062.Jan 9 2021, 2:16 AM

New icons for Athenian long wall, differentiating from Crenellations and iphicratean reforms differentiating from unlock champion infantry.

borg- updated this revision to Diff 15079.EditedJan 9 2021, 6:14 PM

New icons

  • Immortals
  • Fertility festival
  • Persian levy cavalry (currently same as cavalry ranged attack)/infantry
  • Equine transport (currently same as cavalry ranged attack)
  • Commercial Treatry (currently same as sibylline books)
borg- added a comment.Jan 10 2021, 1:00 PM

Pls guys some look here.

Silier added a subscriber: Silier.EditedJan 10 2021, 1:13 PM

images looks like without content, i was not able to get them, maybe upload zip to diff or something

Nescio added a comment.Jan 10 2021, 1:25 PM

Perhaps you could make a forum post (with spoilers), showing the proposed new icons next to the current, old ones, to get more feedback from a wider audience (and avoid phabricator's quirks)?

Stan added a comment.Jan 10 2021, 1:30 PM

Images are in the PM no?

Silier added a comment.Jan 12 2021, 5:07 PM

ok, so if @Stan agrees on icons, he can commit them beforehand :)

Stan added a comment.Jan 13 2021, 12:38 PM

Icons should be good now, this needs a rebase.

borg- updated this revision to Diff 15315.EditedJan 15 2021, 2:55 AM
borg- retitled this revision from Upgrade/add some portraits to Upgrade techs portraits..
borg- edited the summary of this revision. (Show Details)
borg- edited the test plan for this revision. (Show Details)
borg- removed a subscriber: wowgetoffyourcellphone.

Rebase!

Some icons I have already updated in other patches D3356 D3357.

borg- updated this revision to Diff 15548.Jan 20 2021, 12:14 AM
borg- retitled this revision from Upgrade techs portraits. to Upgrade ship_movement_speed / tower_health icons.
borg- edited the summary of this revision. (Show Details)

Rebase

borg- added a subscriber: wraitii.Jan 20 2021, 7:20 PM

@wraitii opnion?

wraitii accepted this revision.Jan 20 2021, 7:29 PM

Sure yeah

This revision is now accepted and ready to land.Jan 20 2021, 7:29 PM
Closed by commit rP24737: Upgrade ship_movement_speed / tower_health icons (authored by wraitii). · Explain WhyJan 20 2021, 10:40 PM
This revision was automatically updated to reflect the committed changes.
wraitii added a commit: rP24737: Upgrade ship_movement_speed / tower_health icons.
Owners added a subscriber: Restricted Owners Package.Jan 20 2021, 10:40 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
technologies/
2 lines
2 lines

Diff 15586

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/ship_movement_speed.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/tower_health.json

Loading...
Wildfire Games · Phabricator