This is WIP because atm I'm not changing anything.
As shown in the test, the behaviour is a bit odd right now. We 'AND' specific 'affects', when I think we should probably replace them (and/or force to either affect all or specify per-class).
Also the code is buggy somewhat, the modifiers are odd.
Details
Details
- Reviewers
- None
Run the tests, agree that some changes are needed.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 14798 Build 31794: Vulcan Build Jenkins Build 31793: Vulcan Build (macOS) Jenkins Build 31792: Vulcan Build (Windows) Jenkins Build 31791: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file
See https://jenkins.wildfiregames.com/job/macos-differential/2723/display/redirect for more details.
Comment Actions
For me, the current behaviour seems quite right. The whole e.g. technology file affects "ClassA" but it has some differentiation for "ClassB", which also needs to be "ClassA".