Page MenuHomeWildfire Games

[gameplay] move shared vision and dropsites to civic centre
ClosedPublic

Authored by Nescio on Jan 11 2021, 12:59 PM.

Details

Summary

This patch is a follow-up to D2999/rP24541.
The unlock shared vision and unlock shared dropsites technologies do not really affect markets, tribute, barter, or traders, therefore these two technologies do not belong there.
This patch moves this two technologies from the market to the civic centre instead, which already has the conceptually somewhat similar unlock spies and counterespionage technologies. As a consequence:

  • The unlock shared vision and unlock shared dropsites are available at game start, making it easier for allies to cooperate, improving team games.
  • If at some point a civ (e.g. cart) gets a discount on market technologies as a civ bonus, then these two technologies are no longer discounted too.
Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 11 2021, 12:59 PM
Owners added a subscriber: Restricted Owners Package.Jan 11 2021, 1:00 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2759/display/redirect for more details.

Nescio requested review of this revision.Jan 11 2021, 1:15 PM

I'd say it still would need a market then, for the reasoning behind shared LOS is traders sharing info?

You can see everything your allies see, not just their traders.

"Information is sold at the markets." ;)

Not anything blocking, merely my two cents ;)

Diplomacy tends to be a political affair, not a commercial business.

@Angen, @borg-, @Stan, opinions on this?

borg- added a comment.EditedJan 12 2021, 10:33 PM

I don't have a strong opinion on that. Bit more in favor of the patch. It seems to make sense in both buildings, more to cc.
Choose between the two I choose in cc.
That said, the patch has my yes.

borg- accepted this revision.Jan 13 2021, 3:16 AM
This revision is now accepted and ready to land.Jan 13 2021, 3:16 AM
This revision was automatically updated to reflect the committed changes.