Page MenuHomeWildfire Games

[gameplay] 10% loot for support units
ClosedPublic

Authored by Angen on Jan 11 2021, 8:17 PM.

Details

Summary

Change loot for support units and citizen soldiers following champion loot pattern from rP23868

however there is this one rP18738 from 2016 loot balance, but some values looks very strange compared to which resource is needed to construction and what the loot is

10% loot is present for other citizen soldiers so this makes quite sense from my perspective

Test Plan

discuss

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Jan 11 2021, 8:17 PM
Owners added a subscriber: Restricted Owners Package.Jan 11 2021, 8:17 PM
Angen published this revision for review.Jan 11 2021, 8:18 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(dbghelp.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(file_stats.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblowlevel_dbg.a(vfs_path.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Framework

See https://jenkins.wildfiregames.com/job/macos-differential/2775/display/redirect for more details.

Nescio added a subscriber: Nescio.Jan 11 2021, 8:42 PM

Well spotted!
I agree it makes sense to make loot proportional to costs for these units too. 10% is fine for support units, that's also what (most?) soldiers have. (Don't forget the slave template, though.) Since support units can't fight back, I'd favour removing their <xp>.
As for ships, I don't think they must have 10%, because they're a bit different. Structures have loot 20% of their costs, and that's also the percentage I proposed for siege engines in D3319. Speaking of which, feel free to include siege engines loot standardization here in this patch too, they're a bit out of place in D3319.
On the other hand, ships sink, so I'd be fine with giving them no resource loot at all as well. And maybe make warship loot <xp> proportional to their health?

borg- added a subscriber: borg-.Jan 11 2021, 9:01 PM

Well spotted!
I agree it makes sense to make loot proportional to costs for these units too. 10% is fine for support units, that's also what (most?) soldiers have. (Don't forget the slave template, though.) Since support units can't fight back, I'd favour removing their <xp>.
As for ships, I don't think they must have 10%, because they're a bit different. Structures have loot 20% of their costs, and that's also the percentage I proposed for siege engines in D3319. Speaking of which, feel free to include siege engines loot standardization here in this patch too, they're a bit out of place in D3319.
On the other hand, ships sink, so I'd be fine with giving them no resource loot at all as well. And maybe make warship loot <xp> proportional to their health?

I think exactly the same.

Angen updated this revision to Diff 15186.Jan 12 2021, 4:38 PM
Angen retitled this revision from [gameplay] 10% loot for support units and ships. to [gameplay] 10% loot for support units.

exclude ships and do it separately,
I would keep the xp, although most of them cant fight back, they do move and particulary ranged units should get better when shooting at moving target or any target

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file f

See https://jenkins.wildfiregames.com/job/macos-differential/2798/display/redirect for more details.

borg- added a comment.Jan 12 2021, 5:00 PM

Better now. For me no problem If u want keep xp.

I would keep the xp,

For me no problem If u want keep xp.

Fine by me, if the value is proportional to their health. I'll leave it up to you to choose a suitable percentage.

binaries/data/mods/public/simulation/templates/template_unit_support_slave.xml
50 ↗(On Diff #15186)

Indentation.

Angen added a comment.Jan 12 2021, 5:26 PM

they are not, what is the prefered health xp ratio ?

They're weak, so I wouldn't make it too high. I don't really see how killing civilians would make you a better soldier. How about 10%?

borg- added a comment.Jan 12 2021, 5:42 PM

Much of the training was against immobile targets, so against a moving target it's still an experience.

Nescio added inline comments.Jan 12 2021, 6:28 PM
binaries/data/mods/public/simulation/templates/template_unit_support.xml
9 ↗(On Diff #15192)

Purge here, insert in *_trader.xml.

binaries/data/mods/public/simulation/templates/template_unit_support_slave.xml
49 ↗(On Diff #15192)

?

binaries/data/mods/public/simulation/templates/units/spart/support_female_citizen.xml
21 ↗(On Diff #15192)

<xp op="add">1<xp>

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//Forc

See https://jenkins.wildfiregames.com/job/macos-differential/2802/display/redirect for more details.

Build is green

builderr-debug-gcc7.txt
In file included from ../../../source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.cpp:17:
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h: In lambda function:
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h:203:17: warning: unused parameter 'includePath' [-Wunused-parameter]
     const CStr& includePath, CStr& out) {
     ~~~~~~~~~~~~^~~~~~~~~~~
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h: In lambda function:
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h:220:17: warning: unused parameter 'includePath' [-Wunused-parameter]
     const CStr& includePath, CStr& out) {
     ~~~~~~~~~~~~^~~~~~~~~~~
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/tests/test_Preprocessor.h:220:36: warning: unused parameter 'out' [-Wunused-parameter]
     const CStr& includePath, CStr& out) {
/zpool0/gcc7/source/third_party/ogre3d_preprocessor/test

See https://jenkins.wildfiregames.com/job/docker-differential/4465/display/redirect for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 12 2021, 8:30 PM
This revision was automatically updated to reflect the committed changes.