Page MenuHomeWildfire Games

[gameplay] new gaul cavalry civ bonus
ClosedPublic

Authored by Nescio on Jan 11 2021, 8:26 PM.

Details

Summary

This patch introduces a new civ bonus for the Gauls, giving their cavalry +10% melee attack damage. The idea is to differentiate them a bit more from other factions, especially the Britons, though hopefully without unbalancing the game.

Test Plan

Agree with the concept, the proposed values, and the text strings.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 11 2021, 8:26 PM
Owners added a subscriber: Restricted Owners Package.Jan 11 2021, 8:26 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2776/display/redirect for more details.

Nescio requested review of this revision.Jan 11 2021, 8:36 PM
borg- added a subscriber: borg-.Jan 12 2021, 3:29 AM

It has historical value. Do we continue with the current bonus inherited from a 23?

This bonus put Britons at a disadvantage as it has the same standard bonus?

Gauls also have an extra farming technology (D2668/rP23803) and there is a proposal to give them a carnyx aura unit (D3320), so yes, Gauls seem to have an advantage over the Britons, so maybe the celt_structures bonus should be limited to brit only. However, that discussion belongs in D2841; doing one bonus at a time makes patches simpler, so let's concentrate here on the proposed cavalry bonus.

borg- accepted this revision.Jan 13 2021, 3:13 AM

For me the bonus is good (use the same as my mod), not dangerous for balance and has a historical accuracy, so I accept, but we need something for brit.

This revision is now accepted and ready to land.Jan 13 2021, 3:13 AM
This revision was automatically updated to reflect the committed changes.