Page MenuHomeWildfire Games

[gameplay] alter ptol structure civ bonus
ClosedPublic

Authored by Nescio on Jan 11 2021, 9:20 PM.

Details

Summary

This is yet another patch that makes civilizations more similar. On the other hand, it works well with @wraitii's forum suggestion to look at civs as groups.
As you probably know, ptol houses, corrals, farmsteads, and storehouses don't cost resources, but have a higher building time and less health.
Some people object to free houses (e.g. @Sundiata in this forum post). Moreover, while sun-dried mud bricks were indeed a common building in Egypt, they were used elsewhere as well.
This patch therefore removes the current Ptolemaic civ bonus, and instead gives ptol houses and economic structures −50% wood cost, but +50% build time.

Test Plan

Check for mistakes and omissions, agree with the concept and the proposed values.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 11 2021, 9:20 PM
Owners added a subscriber: Restricted Owners Package.Jan 11 2021, 9:20 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2777/display/redirect for more details.

Nescio requested review of this revision.Jan 11 2021, 9:28 PM
borg- added a subscriber: borg-.EditedJan 12 2021, 3:32 AM

I like how it works in a23, having less health. I also agree that it shouldn't cost 0 resources, this is illogical and is the only thing that would change. Affecting other civilizations seems to me a very big step now.

I like the chosen value of 50%.

Affecting other civilizations seems to me a very big step now.

It is. Should that be left out?

Nescio updated this revision to Diff 15202.Jan 12 2021, 7:56 PM
Nescio retitled this revision from [gameplay] replace ptol structure civ bonus to [gameplay] alter ptol structure civ bonus.
Nescio edited the summary of this revision. (Show Details)
  • don't add it to cart, kush, pers, per @borg-

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2807/display/redirect for more details.

borg- accepted this revision.Jan 12 2021, 8:54 PM

For me a value addition makes a lot more sense than 0 costs.

This revision is now accepted and ready to land.Jan 12 2021, 8:54 PM
Freagarach added inline comments.
binaries/data/mods/public/simulation/data/technologies/civbonuses/ptol_structures.json
14 ↗(On Diff #15202)
This revision was automatically updated to reflect the committed changes.

Well, I'm glad someone looks critically at the actual modifications! I noticed I'm making quite a few mistakes lately, probably the result of writing many patches in quick succession. Rushing things is risky, I know.

binaries/data/mods/public/simulation/data/technologies/civbonuses/ptol_structures.json
14 ↗(On Diff #15202)

No hard feelings. We all make mistakes, especially under pressure. As long as we can point them out to eachother respectfully it's good :) (For me at least.)