Differential D3332
Add a "Catafalque Bonuses" page Authored by s0600204 on Jan 11 2021, 11:18 PM. Tags None Subscribers
Details Allowing comparison between different civ's catafalques. (By popular request on D294.)  Any civ that lacks a catafalque template is skipped - its emblem doesn't appear on the page. NOTE: This change expects catafalques to have a specific name (catafalque.xml), and be in a certain location (simulation/templates/units/{civ}/). If neither of these are true, a catafalque will not be shown. (This affects modders, or any contributors who wish to relocate or rename vanilla templates.) NOTE: This revision contains two binary (image) files, which arc might not download automatically when applying this patch to test locally.
For bonus points:
Diff Detail
Event TimelineComment Actions Build is green builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu See https://jenkins.wildfiregames.com/job/macos-differential/2780/display/redirect for more details. Comment Actions No strong opinion, but the current location of the button suggests that it shows all the catafalques from the civ one is viewing, perhaps a separate button in the learn to play menu? I tested this and confirmed no errors, even when removing catafalques from the civs until none were left.
Comment Actions Works good in Delenda Est. https://i.imgur.com/u7bUicd.png I mirror this opinion, that the button should go in the Learn to Play slide out, and then also maybe at the bottom of the Structure Tree. Comment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/F See https://jenkins.wildfiregames.com/job/macos-differential/2917/display/redirect for more details. | ||||||||||||||||||||