Page MenuHomeWildfire Games

Fix attack-move serialization (quick fix)
AbandonedPublic

Authored by wraitii on Jan 12 2021, 9:58 AM.

Details

Reviewers
None
Trac Tickets
#5908
Summary

This is a quick-fix for #5908.
It fixes the reported issue, but I think it's pretty ugly and I'm working on a revert of rP24167 in paralell. If that fails, we'll have to merge this one.

Test Plan

Attack-walk, then quicksave.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
temp
Lint
Lint OK
SeverityLocationCodeMessage
Errorbinaries/data/mods/public/simulation/helpers/Commands.js:53ESLintBear (no-use-before-define)ESLintBear (no-use-before-define)
Errorbinaries/data/mods/public/simulation/helpers/Commands.js:57ESLintBear (no-use-before-define)ESLintBear (no-use-before-define)
Warningbinaries/data/mods/public/simulation/helpers/Commands.js:524ESLintBear (operator-linebreak)ESLintBear (operator-linebreak)
Unit
No Unit Test Coverage
Build Status
Buildable 14896
Build 32106: Vulcan BuildJenkins
Build 32105: Vulcan Build (macOS)Jenkins
Build 32104: Vulcan Build (Windows)Jenkins
Build 32103: arc lint + arc unit

Event Timeline

wraitii created this revision.Jan 12 2021, 9:58 AM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2782/display/redirect for more details.

wraitii requested review of this revision.Jan 12 2021, 10:07 AM
wraitii abandoned this revision.Jan 12 2021, 7:44 PM

Not necessary following rP24563