FFP removed, so we don't need to spend CPU time on that.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- rP24599: Removes CPU lighting after no FFP
- Apply the patch and compile the game
- Make sure that everything works as before
- Check that CPU lighting doesn't still present somewhere in changed code
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedba
See https://jenkins.wildfiregames.com/job/macos-differential/2816/display/redirect for more details.
|101 ↗||(On Diff #15219)|
struct, mostly as POD.
|172 ↗||(On Diff #15219)|
It'd be right if it'd return const char*, but it returns CStr. So the return value will be constructed before the buf will be destroyed.
|553 ↗||(On Diff #15219)|
We're already checking. It's not a regression. Just a notice to validate the place after removing RenderPath::FIXED from real code.