Page MenuHomeWildfire Games

Fix shadows-on-water option.
ClosedPublic

Authored by wraitii on Jan 13 2021, 9:35 AM.

Details

Summary

rP17737 used the wrong name, and subsequent code followed.
I picked 'watershadows' for convenience and as that reduces C++ changes.

Refs rP24228

Reported by: vladislavbelov

Test Plan

Test shadows on water from in-game & config.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 13 2021, 9:35 AM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file f

See https://jenkins.wildfiregames.com/job/macos-differential/2823/display/redirect for more details.

wraitii requested review of this revision.Jan 13 2021, 9:51 AM
vladislavbelov accepted this revision.Jan 13 2021, 10:50 AM
This revision is now accepted and ready to land.Jan 13 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.