Page MenuHomeWildfire Games

Fix gamesetup map size not updating for clients.
ClosedPublic

Authored by wraitii on Wed, Jan 13, 5:53 PM.

Details

Summary

Clients don't get map size updates shown in the gamesetup (they do appear in the description).
The cause is an incorrect optimisation.

Test Plan

Host a game, join it, change the map size, note the bug is fixed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Wed, Jan 13, 5:53 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2847/display/redirect for more details.

wraitii requested review of this revision.Wed, Jan 13, 5:59 PM

Fixes the issue indeed.

binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns/MapSize.js
36 ↗(On Diff #15262)

One could also check whether the size has changed?

wraitii added inline comments.Thu, Jan 14, 5:47 PM
binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns/MapSize.js
36 ↗(On Diff #15262)

Not going to bother with this before D3243

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jan 15, 8:48 AM
This revision was automatically updated to reflect the committed changes.