Clients don't get map size updates shown in the gamesetup (they do appear in the description).
The cause is an incorrect optimisation.
Details
Details
- Reviewers
- None
- Commits
- rP24614: Fix gamesetup map size not updating for clients.
Host a game, join it, change the map size, note the bug is fixed.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 15009 Build 32444: Vulcan Build Jenkins Build 32443: Vulcan Build (macOS) Jenkins Build 32442: Vulcan Build (Windows) Jenkins Build 32441: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
builderr-debug-macos.txt ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking. ld: warning: text-based stu
See https://jenkins.wildfiregames.com/job/macos-differential/2847/display/redirect for more details.
Comment Actions
Fixes the issue indeed.
| binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns/MapSize.js | ||
|---|---|---|
| 36 | One could also check whether the size has changed? | |