Page MenuHomeWildfire Games

Fix shared dropsite bug.
ClosedPublic

Authored by Freagarach on Jan 14 2021, 9:48 AM.

Details

Summary

Introduced in rP24501. It needed to use the filtered entities, but failed to do so.

Test Plan

According to @wraitii there was a bug, let them see whether it is fixed ;)

Check this was the idea all along.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 14 2021, 9:48 AM
Freagarach added inline comments.
binaries/data/mods/public/gui/session/unit_actions.js
1484 ↗(On Diff #15286)

Rather use this I guess.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2857/display/redirect for more details.

wraitii requested review of this revision.Jan 14 2021, 9:56 AM
Stan added a subscriber: Stan.Jan 14 2021, 10:20 AM
Stan added inline comments.
binaries/data/mods/public/gui/session/unit_actions.js
1484 ↗(On Diff #15286)
wraitii updated this revision to Diff 15288.Jan 14 2021, 10:26 AM

Better fix?
I'm not too sure what this does, @Freagarach feel free to commandeer.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2859/display/redirect for more details.

Freagarach commandeered this revision.Jan 14 2021, 10:50 AM
Freagarach added a reviewer: wraitii.
Freagarach edited the summary of this revision. (Show Details)Jan 14 2021, 10:52 AM
Freagarach edited the test plan for this revision. (Show Details)

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2860/display/redirect for more details.

wraitii accepted this revision.Jan 14 2021, 11:06 AM
wraitii added inline comments.
binaries/data/mods/public/gui/session/unit_actions.js
1485 ↗(On Diff #15289)

I missed that this was sharable.

This revision is now accepted and ready to land.Jan 14 2021, 11:06 AM
This revision was automatically updated to reflect the committed changes.
Freagarach marked an inline comment as done.
Owners added a subscriber: Restricted Owners Package.Jan 14 2021, 1:29 PM