Page MenuHomeWildfire Games

Fix PetraAI not building many houses.
ClosedPublic

Authored by Freagarach on Jan 14 2021, 10:25 AM.

Details

Summary

PetraAI assumes every entity has a Population component, which is not the case, leading to a NaN in population calculation.
Fixes rP24394.

Test Plan

Play with/against PetraAI.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Jan 14 2021, 10:25 AM
Owners added a subscriber: Restricted Owners Package.Jan 14 2021, 10:25 AM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2858/display/redirect for more details.

Freagarach requested review of this revision.Jan 14 2021, 10:34 AM
wraitii accepted this revision.Jan 14 2021, 8:08 PM
wraitii added a subscriber: wraitii.

Same diagnostic + tested to work -> merge.

This revision is now accepted and ready to land.Jan 14 2021, 8:08 PM
Silier accepted this revision.Jan 14 2021, 9:30 PM
This revision was automatically updated to reflect the committed changes.