Page MenuHomeWildfire Games

Fix lag on OOS with AIs
ClosedPublic

Authored by wraitii on Jan 14 2021, 11:35 AM.

Details

Reviewers
None
Commits
rP24641: Fix lag on OOS with AIs
Trac Tickets
#5917
Summary

Following rP24462, the OOS debugSerializer would try to serialize AI objects entirely. This is extremely slow (might be an infinite loop in some cases).
Instead, it should print the result of Serialize() in those cases.

Test Plan

Have an OOS with AIs.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 14 2021, 11:35 AM

Build has FAILED

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framewor

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2861/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2861/display/redirectconsole

wraitii requested review of this revision.Jan 14 2021, 11:40 AM
wraitii updated this revision to Diff 15328.Jan 15 2021, 9:13 AM

Fix tests.

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library fi

See https://jenkins.wildfiregames.com/job/macos-differential/2870/display/redirect for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2021, 11:33 AM
Closed by commit rP24641: Fix lag on OOS with AIs (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.