Page MenuHomeWildfire Games

[gameplay] fix a few oversights
ClosedPublic

Authored by Nescio on Jan 15 2021, 10:23 PM.

Details

Summary

This patch fixes a few oversights:

  • When redoing D3287, a typo slipped in, spotted by @borg-: “wood” instead of “food”.
  • From the same patch, @Angen suggested to change a technology name, from “Metal Shield” to “Metal Rim”.
  • When redoing D2494, I missed that the ptol polybolos has a third less reload time; as a consequence its damage per second is now 50% higher than that of other bolt-shooters; this patch fixes that by adjusting its damage.
  • Likewise, D3235 adjusted archer attacks but omitted the crossbowman, which currently has half the base damage of its champion counterpart but three times the reload time, which means its damage per second is only one-sixth the archer's; this patch raises its base damage sixfold to give the crossbowman the same damage per second as the archer.
Test Plan

Consider if there is anything else.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 15 2021, 10:23 PM
Owners added a subscriber: Restricted Owners Package.Jan 15 2021, 10:23 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2885/display/redirect for more details.

Nescio requested review of this revision.Jan 15 2021, 10:28 PM
Freagarach added inline comments.
binaries/data/mods/public/simulation/templates/units/mace/champion_infantry_crossbowman.xml
8 ↗(On Diff #15359)

Could as well ask @borg- to look at D2886 ;)

Nescio added inline comments.
binaries/data/mods/public/simulation/templates/units/mace/champion_infantry_crossbowman.xml
8 ↗(On Diff #15359)

D2886 needs to be rebased.
@ValihrAnt seemed to agree on this, though: https://code.wildfiregames.com/D2886#137691

wraitii accepted this revision.Jan 16 2021, 4:28 PM
This revision is now accepted and ready to land.Jan 16 2021, 4:28 PM
This revision was automatically updated to reflect the committed changes.