Differential D3382

Removes useless option to show sky
ClosedPublic
Actions

Authored by vladislavbelov on Jan 16 2021, 4:26 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP24651: Removes useless option to show sky

Summary

It's been useless for a while, since it does cost nothing and it reserves place in options, which makes them bigger.

Test Plan

Apply the patch and compile the game
Make sure you see skies always

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jan 16 2021, 4:26 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
../../../source/ps/Hotkey.cpp:120:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
1 warning generated.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.

See https://jenkins.wildfiregames.com/job/macos-differential/2894/display/redirect for more details.

Harbormaster completed remote builds in B15109: Diff 15381.Jan 16 2021, 5:16 PM

vladislavbelov requested review of this revision.Jan 16 2021, 5:16 PM

Looks alright. Save works for translators.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2021, 10:16 PM

Closed by commit rP24651: Removes useless option to show sky (authored by vladislavbelov). · Explain Why

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP24651: Removes useless option to show sky.

Owners added a subscriber: Restricted Owners Package.Jan 16 2021, 10:16 PM