Differential D3389

Fix game speed button being unusable in min resolution
ClosedPublic
Actions

Authored by Imarok on Jan 16 2021, 10:10 PM.

Details

Reviewers

ffffffff

Commits

rP24735: Fix game speed button being unusable in min resolution

Trac Tickets

#5926

Summary

When one observes a player the follow button text overlays the game speed button so the game speed button gets unusable.
The code test if it has to hide the follow button text but only does so on windowResize.
Do it also on init.

Test Plan

Test if the follow button text gets always hidden when it should.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Imarok created this revision.Jan 16 2021, 10:10 PM

Build has FAILED

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2908/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2908/display/redirectconsole

Harbormaster completed remote builds in B15131: Diff 15401.Jan 17 2021, 1:02 AM

Imarok requested review of this revision.Jan 17 2021, 1:02 AM

Works as expected. Button is again usable.
Lul semicolon missing. Well imarok will handle that. :D

This revision is now accepted and ready to land.Jan 17 2021, 1:18 AM

In D3389#150463, @ffffffff wrote:

Works as expected. Button is again usable.
Lul semicolon missing. Well imarok will handle that. :D

I knew I uploaded a diff with a missing semi. I just couldn't find the diff anymore xD

This revision was landed with ongoing or failed builds.Jan 20 2021, 9:49 PM

Closed by commit rP24735: Fix game speed button being unusable in min resolution (authored by Imarok). · Explain Why

This revision was automatically updated to reflect the committed changes.

Imarok added a commit: rP24735: Fix game speed button being unusable in min resolution.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

top_panel/

FollowPlayer.js

1 line

Diff 15582

View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/FollowPlayer.js

Fix game speed button being unusable in min resolutionClosedPublicActions