Fix mod selector "refresh list" button.
ClosedPublic
Actions

Authored by wraitii on Jan 17 2021, 5:07 PM.

Details

Reviewers: None
Commits: rP24681: Fix mod selector "refresh list" button.
Trac Tickets: #5931

Summary

Object.Keys() on GUI object doesn't work following rP24229.
I don't think it really should have worked in the first place, but this simply replaces with explicit calls instead.

Test Plan

Refresh the mod list.

Reported by: Stan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 17 2021, 5:07 PM

Build has FAILED

builderr-debug-macos.txt
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled he

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2922/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2922/display/redirectconsole

Harbormaster completed remote builds in B15166: Diff 15434.Jan 17 2021, 6:45 PM

wraitii requested review of this revision.Jan 17 2021, 6:45 PM

Works for me.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2021, 12:33 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP24681: Fix mod selector "refresh list" button. (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24681: Fix mod selector "refresh list" button..