We've always been supposed to be able to trade with neutrals, and the Trade component allows it, so this gui restriction should be removed
Details
Details
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces.
Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
../../../source/lib/tex/tex_png.cpp: In member function ‘virtual Status TexCodecPng::encode(Tex*, DynArray*) const’:
../../../source/lib/tex/tex_png.cpp:309:9: warning: variable ‘ret’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered]
Status ret = ERR::FAIL;
^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
void CChart::HandleMessage(SGUIMessage& Message)
^
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!http://jw:8080/job/phabricator/81/ for more details.
Comment Actions
We have to keep in mind that the alliance and neutral stance should be distinct and implement different use cases. Besides the ability to trade, only the shared ally vision and territory decay comes to my mind. For example if we had an option to limit the number of alliances per player to N, this would incentivize players to pick their allies more wisely. But you're likely right that it makese sense to allow trade amongst neutral players, it isn't unrealistic either.
Comment Actions
In order to keep distinct the position of a player between neutral and allied, probably trade should be allowed between allies only, making clear the player's position.