Page MenuHomeWildfire Games

Fix market waypoints.
ClosedPublic

Authored by wraitii on Jan 17 2021, 6:05 PM.

Details

Reviewers
None
Commits
rP24676: Fix market waypoints.
Trac Tickets
#5923
Summary

There is no need to explicitly call MoveTo() in PerformTradeandmovetonextmarket

Test Plan

Create a trade route with waypoints.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 17 2021, 6:05 PM

Build has FAILED

builderr-debug-macos.txt
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
1 error generated.
make[1]: *** [obj/engine_Debug/CConsole.o] Error 1
make[1]: *** Waiting for unfinished jobs....
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modif

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2923/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2923/display/redirectconsole

Stan added a subscriber: Stan.Jan 17 2021, 6:11 PM
Stan added inline comments.
binaries/data/mods/public/simulation/components/UnitAI.js
5783–5789 ↗(On Diff #15436)
wraitii requested review of this revision.Jan 17 2021, 7:02 PM
Imarok added a subscriber: Imarok.Jan 17 2021, 8:27 PM

Tried setting three waypoints? first to somewhere, second to the other market, third to somewhere else?
(That gives quite strange behaviour.)

Tried setting three waypoints? first to somewhere, second to the other market, third to somewhere else?
(That gives quite strange behaviour.)

Besides of that it works.

Tried setting three waypoints? first to somewhere, second to the other market, third to somewhere else?

Besides of that it works.

As discussed on IRC this was already weird behaviour in A23, and I won't fix it right now because the code looks rather complicated. Thanks for reporting & testing, I'll merge this tomorrow.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2021, 12:00 PM
This revision was landed with ongoing or failed builds.
Closed by commit rP24676: Fix market waypoints. (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.