Page MenuHomeWildfire Games

Fix MapBrowser in MP
ClosedPublic

Authored by wraitii on Jan 17 2021, 8:56 PM.

Details

Reviewers
None
Commits
rP24684: Fix MapBrowser in MP
Summary

When submitting the selection, the network settings aren't synchronised, which is bad. Missed in rP24459.

Test Plan

Run an MP game. Have a client join. Select a map using the MapBrowser -> client isn't updated. Do anything networkedsynched -> client is updated.
With the patch, it works as expected.

Reported by: Imarok

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 17 2021, 8:56 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file f

See https://jenkins.wildfiregames.com/job/macos-differential/2932/display/redirect for more details.

wraitii requested review of this revision.Jan 17 2021, 9:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2021, 2:22 PM
Closed by commit rP24684: Fix MapBrowser in MP (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.