Display Auras for Heroes and Relics in the top panel
ClosedPublic
Actions

Authored by elexis on Apr 16 2017, 6:48 AM.

Details

Reviewers

Hannibal_Barca
sanderd17
fatherbushido

Commits

rP19536: Display aura tooltips for the entities in the top panel (currently heroes and…

Summary

Following D289 we can see relics in the top panel. In order to quickly lookup their contents, it would be nice to display them quickly.
Same is true for the other relevant entities displayed there, like heroes or wonders (once they can be added from trigger scripts, so it would work for the treasure seeker female too).
This somewhat helps with the use case of D294 but one could also argue with the hammer-nail argument if one isn't fond of those units.

(This still doesn't allow comparison of all existing relic units, but allows the player and observer to lookup the auras quicker than selecting it and hovering the icon to see the tooltip)

Test Plan

Convince yourself that we can't add the auras tooltip to the existing list, f.e. compare with selection_details.js.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1226
Build 1935: Vulcan Build	Jenkins
Build 1934: arc lint + arc unit

Event Timeline

elexis created this revision.Apr 16 2017, 6:48 AM

elexis edited the summary of this revision. (Show Details)Apr 16 2017, 6:53 AM

elexis added reviewers: • leper, Hannibal_Barca.

elexis edited the summary of this revision. (Show Details)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/781/ for more details.

Harbormaster completed remote builds in B1135: Diff 1272.Apr 16 2017, 8:19 AM

• leper edited reviewers, added: sanderd17; removed: • leper.Apr 17 2017, 10:49 PM

• leper added inline comments.

binaries/data/mods/public/gui/session/session.js
973	Can't you add that to the list above (you might need a variant of `getAurasTooltip`)?

elexis added inline comments.Apr 17 2017, 10:50 PM

binaries/data/mods/public/gui/session/session.js
973	Does it make sense to add a proxy function that is used only once though?

Moved the outsider check from one place to another.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/846/ for more details.

Harbormaster completed remote builds in B1226: Diff 1409.Apr 21 2017, 9:56 PM

(I shouldn't have asked the tough question on whether to make Templates.js and Auras.js return the same object)

elexis mentioned this in D447: Clean a bit auras gui info parsing.May 7 2017, 8:08 PM

Since D447 did the harder part, there is nothing left to do here.