Page MenuHomeWildfire Games

[gameplay] fix unlock shared dropsites requirement
Needs RevisionPublic

Authored by Nescio on Jan 18 2021, 10:09 PM.

Details

Reviewers
wraitii
Group Reviewers
Balancing
Summary

The “unlock shared dropsites” technology is now independent from the “unlock shared vision” technology (D2999/rP24541) and available at the civic centre (D3321/rP24605) in the village phase, to encourage cooperation at game start.
However, it still has a three traders requirement, which is problematic, since you need to be in the town phase to be able to build a market to train traders.
This patch removes that requirement.

Test Plan

Agree.

Event Timeline

Nescio created this revision.Jan 18 2021, 10:09 PM
Owners added a subscriber: Restricted Owners Package.Jan 18 2021, 10:10 PM
Nescio edited the summary of this revision. (Show Details)Jan 18 2021, 10:11 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2953/display/redirect for more details.

Nescio requested review of this revision.Jan 18 2021, 10:15 PM
wraitii accepted this revision.Jan 19 2021, 9:36 AM
This revision is now accepted and ready to land.Jan 19 2021, 9:36 AM
wraitii requested changes to this revision.Jan 19 2021, 9:44 AM

Er actually Freagarach convinced me that this is a fun requirement -> I'd just add that it requires phase_town to make things explicit.

This revision now requires changes to proceed.Jan 19 2021, 9:44 AM

To encourage team play from the beginning, we'd need a "Shared Allied Vision" option in game setup instead of moving the Shared Allied Vision tech to Village phase. Perhaps enabling the option could auto-research the tech.

"Standard" vision enabled would keep the tech and it would require Town Phase. I would require a Market though, instead of an arbitrary 3 traders. I don't know of any Diffs specifically for this tech/issue though, so I'm mentioning it here.

For this particular tech (Shared Dropsites), perhaps also require a Market, or make it supersede Shared Vision. So, Shared Vision + Market = Shared Dropsites?

Just some ideas.

or make it supersede Shared Vision. So, Shared Vision + Market = Shared Dropsites?

I would agree, but rP24541 :(

borg- added a subscriber: borg-.Thu, Feb 25, 6:17 PM

I am willing to accept. I really like this change.