Page MenuHomeWildfire Games

Fix SDL double clicking on mouse movement.
ClosedPublic

Authored by wraitii on Jan 19 2021, 10:04 AM.

Details

Reviewers
None
Commits
rP24698: Prevent double-click when moving the mouse.
Trac Tickets
#5920
Summary

SDL 2.0.9 introduced a 32-pixel freedom for double clicks to register, which kind of breaks double clicking on Windows.
This uses the hint to revert that to 1.

The platform difference has been reported: https://bugzilla.libsdl.org/show_bug.cgi?id=5482

See https://hg.libsdl.org/SDL/rev/f081a5675f93 for the commit.

Test Plan

Test double-clicking with some movement on windows. You have to be under 500ms and 32 pixels.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 19 2021, 10:04 AM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor

See https://jenkins.wildfiregames.com/job/macos-differential/2956/display/redirect for more details.

wraitii requested review of this revision.Jan 19 2021, 10:18 AM
wraitii edited the summary of this revision. (Show Details)Jan 19 2021, 10:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2021, 2:13 PM
This revision was automatically updated to reflect the committed changes.