Differential D3426

[gameplay] revert rP24693
ClosedPublic
Actions

Authored by Nescio on Jan 19 2021, 7:14 PM.

Details

Reviewers

None

Group Reviewers

Balancing

Commits

rP24718: [Gameplay] - Remove starting hoplite from Spartans.

Summary

Requested by @ValihrAnt, as title says.

Reverts rP24693

Test Plan

Trivial.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 19 2021, 7:14 PM

Owners added a subscriber: Restricted Owners Package.Jan 19 2021, 7:14 PM

Herald added a reviewer: Balancing. · View Herald TranscriptJan 19 2021, 7:14 PM

Nescio mentioned this in rP24693: [Gameplay] - Let Spartans start with a Champion..Jan 19 2021, 7:15 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2974/display/redirect for more details.

Harbormaster completed remote builds in B15251: Diff 15534.Jan 19 2021, 7:22 PM

Nescio requested review of this revision.Jan 19 2021, 7:22 PM

Freagarach edited the summary of this revision. (Show Details)Jan 20 2021, 8:11 AM

Freagarach added reverted changes: rP24693: [Gameplay] - Let Spartans start with a Champion., D3412: [gameplay] let spart start with a champion.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 20 2021, 8:15 AM

Closed by commit rP24718: [Gameplay] - Remove starting hoplite from Spartans. (authored by Freagarach). · Explain Why

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP24718: [Gameplay] - Remove starting hoplite from Spartans..