Subj. Also removes uniform duplication.
It'd good to test it on different platforms.
Differential D3428
Removes shader code duplication to calculate LOS vladislavbelov on Jan 19 2021, 10:19 PM. Authored by
Details
Subj. Also removes uniform duplication. It'd good to test it on different platforms.
Diff Detail
Event TimelineComment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ../../../source/graphics/ShaderProgram.cpp:86:15: warning: 'Reload' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual void Reload() ^ ../../../source/graphics/ShaderProgram.h:124:15: note: overridden virtual function is here virtual void Reload() = 0; ^ ../../../source/graphics/ShaderProgram.cpp:118:15: warning: 'Bind' overrides a member function See https://jenkins.wildfiregames.com/job/macos-differential/2981/display/redirect for more details. Comment Actions Build is green builderr-release-gcc7.txt In file included from ../../../source/pch/atlas/precompiled.h:26: ../../../source/tools/atlas/GameInterface/Messages.h: In function 'void AtlasMessage::fGetTerrainGroupPreviews(AtlasMessage::qGetTerrainGroupPreviews*)': ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] struct sTerrainTexturePreview ^~~~~~~~~~~~~~~~~~~~~~ ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref See https://jenkins.wildfiregames.com/job/docker-differential/4638/display/redirect for more details. Comment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ../../../source/graphics/ShaderProgram.cpp:86:15: warning: 'Reload' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual void Reload() ^ ../../../source/graphics/ShaderProgram.h:124:15: note: overridden virtual function is here virtual void Reload() = 0; ^ ../../../source/graphics/ShaderProgram.cpp:118:15: warning: 'Bind' overrides a member function See https://jenkins.wildfiregames.com/job/macos-differential/2982/display/redirect for more details. Comment Actions Build is green builderr-release-gcc7.txt In file included from ../../../source/pch/atlas/precompiled.h:26: ../../../source/tools/atlas/GameInterface/Messages.h: In function 'void AtlasMessage::fGetTerrainGroupPreviews(AtlasMessage::qGetTerrainGroupPreviews*)': ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] struct sTerrainTexturePreview ^~~~~~~~~~~~~~~~~~~~~~ ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized] ../../../source/tools/atlas/GameInterface/Messages.h:315:8: warning: '#'target_mem_ref See https://jenkins.wildfiregames.com/job/docker-differential/4639/display/redirect for more details. Comment Actions Tested on HP W7
Tested on Dell XPS
Performance on the HP laptop is catastrophic. A23 was barely playable, A24 might not be at all in big battles. |