Page MenuHomeWildfire Games

Add Shift+Space as an alternative Pause hotkey
ClosedPublic

Authored by wraitii on Jan 20 2021, 3:15 PM.

Details

Summary

Mac keyboards have no "Pause" button. As an alternative, introduce 'Shift+Space' (used in Factorio).
P is already used for Patrol.

Test Plan

Agree that this is good.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 20 2021, 3:15 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2991/display/redirect for more details.

wraitii requested review of this revision.Jan 20 2021, 3:30 PM
Langbart added a subscriber: Langbart.EditedJan 21 2021, 6:24 AM

Running rP24739 with patch D3435
patch works for me, it also shows the correct keys in the hotkey menu
Thanks i love that feature

This revision was not accepted when it landed; it landed in state Needs Review.Jan 21 2021, 10:31 AM
This revision was automatically updated to reflect the committed changes.