Differential D3436
Fix "Unit" Attack move. Authored by wraitii on Jan 20 2021, 5:20 PM.
Details
The "unit" attack move modifier is no longer working. The cause is that it is more specific than Attack Move, and so Attack Move no longer triggers alongside it. Since attackmoveunit isn't a proper equivalent to attackmove, just a modifier to it, and it no longer has anything to modify, things don't work. Change that to fix this issue. Reported by: snelius Try using attackmoveunit.
Diff Detail
Event TimelineComment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor See https://jenkins.wildfiregames.com/job/macos-differential/2992/display/redirect for more details. Comment Actions Indeed, it's a bit hacky, hence the question "would you rather I change all 'if attackmove' to 'if attackmove or attackmoveunit'
Comment Actions Would replacing them be less hacky? The question is whether for another case where the actions were a bit more different we would do it? Comment Actions Actually going to change to this if thing, seems easier and less problematic for users. Comment Actions yes
don't understand Comment Actions Would you do the replacement if instead of attackmove and attackmoveUnit it was say patrol and backtowork
then do it, it's probably more maintainable than hacks in the long run. Comment Actions Build is green builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor See https://jenkins.wildfiregames.com/job/macos-differential/3008/display/redirect for more details. Comment Actions Build has FAILED builderr-release-gcc7.txt
In file included from ../../../source/pch/engine/precompiled.h:18,
from ../../../source/ps/Hotkey.cpp:18:
../../../source/lib/precompiled.h:101: error: unterminated #if
#if CONFIG_ENABLE_PCH
../../../source/lib/precompiled.h:78: error: unterminated #if
#if CONFIG_ENABLE_BOOST
../../../source/lib/precompiled.h:57: error: unterminated #if
#if ICC_VERSION
../../../source/lib/precompiled.h:47: error: unterminated #ifdef
# ifdef NDEBUG // release: disable all checks
../../../source/lib/precompiled.h:44: error: unterminated #if
# if MSC_VERSION < 1910
../../../source/lib/precompiled.h:43: error: unterminated #if
#if MSC_VERSION
../../../source/lib/precompiled.h:35: error: unterminated #ifndef
#ifndef MINIMAL_PCH
In file included from ../../../source/pch/engine/precompiled.h:23,
from ../../../source/ps/Hotkey.cpp:18:
../../../source/ps/CStr.h:94: error: unterminated #else
#ifdef _UNICODE
../../../source/ps/CSLink to build: https://jenkins.wildfiregames.com/job/docker-differential/4665/display/redirect Comment Actions Build is green builderr-debug-gcc7.txt
../../../source/network/scripting/JSInterface_Network.cpp: In function 'void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate*, const CStrW&, const CStr8&, const CStr8&)':
../../../source/network/scripting/JSInterface_Network.cpp:169:71: warning: unused parameter 'pCmptPrivate' [-Wunused-parameter]
void JSI_Network::StartNetworkJoinLobby(ScriptInterface::CmptPrivate* pCmptPrivate, const CStrW& playerName, const CStr& hostJID, const CStr& password)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
../../../source/lib/res/h_mgr.cpp: In function 'void h_free_hd(HDATA*)':
../../../source/lib/res/h_mgr.cpp:560:27: warning: 'void* memset(void*, int, size_t)' clearing an object of type 'struct HDATA' with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
memset(hd, 0, sizeof(*hd));
^
../../../source/lib/res/h_mgr.cpp:132:8: note: 'struct HDATA' deSee https://jenkins.wildfiregames.com/job/docker-differential/4666/display/redirect for more details. | ||||||||||||||||