Helps debugging including RenderDoc/apitrace captures.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24768: Allows to override GL version for SDL.
- Apply the patch and compile the game
- Check different versions and make sure RenderDoc captures in case of 3.0 with compatibility
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
So this is interesting and practical. By setting it to true I can hook up renderdoc, however If I put the mode in core instead of compatibility I get a black screen.
binaries/data/config/default.cfg | ||
---|---|---|
58 ↗ | (On Diff #15612) | Maybe you could use int to avoid storing strings |
source/ps/VideoMode.cpp | ||
230 ↗ | (On Diff #15612) | Might need to include CStr |
That's expected, since we just dropped FFP, but 3.3 has nothing about FFP and some related functions.
binaries/data/config/default.cfg | ||
---|---|---|
58 ↗ | (On Diff #15612) | Only for debugging, so it doesn't matter here. |
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor
See https://jenkins.wildfiregames.com/job/macos-differential/3013/display/redirect for more details.
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Cor
See https://jenkins.wildfiregames.com/job/macos-differential/3014/display/redirect for more details.
Just FYI, but you might already now: on Mac OS, "compatibility" is always GL 2.1, and "core" is whatever is supported, generally 4.x something. Might be worth adding that as a comment / ifdef somewhere