Differential D3451

Fix AI undefined error from garrisoned entities.
ClosedPublic
Actions

Authored by wraitii on Jan 22 2021, 3:38 PM.

Details

Reviewers

Silier

Commits

rP24765: Fix AI undefined error from garrisoned entities.

Trac Tickets

#5960

Summary

A classic AI error strikes again. Introduced in rP20072.

Test Plan

Think this must be an entity that's attacked on the same turn it garrisons, which is probably tricky to reproduce, but see ticket replay.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jan 22 2021, 3:38 PM

Owners added a subscriber: Restricted Owners Package.Jan 22 2021, 3:38 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3018/display/redirect for more details.

Harbormaster completed remote builds in B15347: Diff 15624.Jan 22 2021, 3:44 PM

wraitii requested review of this revision.Jan 22 2021, 3:44 PM

Herald added a reviewer: Silier. · View Herald TranscriptJan 22 2021, 3:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 22 2021, 6:35 PM

Closed by commit rP24765: Fix AI undefined error from garrisoned entities. (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24765: Fix AI undefined error from garrisoned entities..