Gather rates are not rounded, so after some modifiers are applied, they appear as ugly decimal numbers.
Limiting them into 2 decimal places for readability and it looks nicer.
Details
Details
- Reviewers
wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24782: Limit gather rate tooltip to 2 decimal places
agree or opose
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file
See https://jenkins.wildfiregames.com/job/macos-differential/3030/display/redirect for more details.
Comment Actions
I would agree that 2 is important. Our gather rates are mostly in the 0.5-1 range, and the 2 decimals are important.
Alternatively we could show gather rates per minute, and then not show decimals at all.
Comment Actions
This writes 1 as 1.00 but I think it's actually OK for readability because all numbers use the same decimals.
Comment Actions
yes we should but I was lazy to start that, see attached comments in https://code.wildfiregames.com/D2053