Page MenuHomeWildfire Games

Adds error shader name logging on reload
ClosedPublic

Authored by vladislavbelov on Jan 23 2021, 10:54 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24814: Adds logging of a shader name on an error after reload.
Summary

Subj.

Test Plan
  1. Apply the patch and compile the game
  2. Throw a preprocessing error, for example add:
# if!

#endif

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
../../../source/graphics/ShaderProgram.cpp:86:15: warning: 'Reload' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual void Reload()
                     ^
../../../source/graphics/ShaderProgram.h:124:15: note: overridden virtual function is here
        virtual void Reload() = 0;
                     ^
../../../source/graphics/ShaderProgram.cpp:118:15: warning: 'Bind' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual void Bind()
                     ^
../../../source/graphics/ShaderProgram.h:135:15: note: overridden virtual function is here
        virtual void Bind() = 0;
                     ^
../../../source/graphics/ShaderProgram.cpp:128:15: warning: 'Unbind' overrides a

See https://jenkins.wildfiregames.com/job/macos-differential/3032/display/redirect for more details.

vladislavbelov requested review of this revision.Jan 24 2021, 3:08 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2021, 2:50 PM
This revision was automatically updated to reflect the committed changes.